zuston opened a new issue, #380:
URL: https://github.com/apache/incubator-uniffle/issues/380

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   When using the storage type of `MEMORY_LOCALFILE_HDFS` and enable the 
fallback strategy of `LocalStorageManagerFallbackStrategy`, it will still fail 
when one disk reached high watermark.
   
   After digging into the code, I found it is caused by the cache in 
MultiStorageManager when invoking the selectStorage in the method of 
`ShuffleFlushManager.processPendingEvents`, that make it lost the chance to use 
the fallback.
   
   But after removing this cache, I still found it still fail, because this 
pending event's retries time always=0, so it will make fallback failed. 
   
   So I rethink this pending queue. Do we really need this in multiple storage? 
I think perhaps not, we could remove this pending queue mechanism when multiple 
storage manager is enabled. Of course, it's still meaningful for single storage 
manager.
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to