zjf2012 commented on issue #475: URL: https://github.com/apache/incubator-uniffle/issues/475#issuecomment-1381200442
> I'm in favor of this. The following code path doesn't need a ConcurrentHashMap as well. > > https://github.com/apache/incubator-uniffle/blob/ddf83843a9fbce8155d159815c351b16eb5a9704/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java#L476 I just re-checked the code. It's different case since the shuffleWriteClientImpl instance is created in RssshuffleManager and shared by different threads. So, it's reasonable to use concurrenthashmp here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
