advancedxy commented on issue #627:
URL: 
https://github.com/apache/incubator-uniffle/issues/627#issuecomment-1434531064

   There's another problem about the operator:
   ```
   func GenerateAddresses(rss *unifflev1alpha1.RemoteShuffleService) string {
        var names []string
        for i := 0; i < int(*rss.Spec.Coordinator.Count); i++ {
                name := GenerateNameByIndex(rss, i)
                serviceName := appendHeadless(name)
                current := fmt.Sprintf("%v:%v", serviceName, 
controllerconstants.ContainerShuffleServerRPCPort)
                names = append(names, current)
        }
        return strings.Join(names, ",")
   }
   ```
   It uses wrong constants, and it should also be updated to use the port in 
the spec.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to