jerqi commented on issue #388: URL: https://github.com/apache/incubator-uniffle/issues/388#issuecomment-1641504392
> This problem still exists (https://github.com/apache/incubator-uniffle/actions/runs/5518411958/jobs/10062325314?pr=982). > > The testGrpcExecutorPool has two state, then verify the metrics. First state : assert the metrics when two thread has already run, but the third thread is not running. Second state: assert the metrics when all thread is done. > > I think the problem is that we can't make sure to enter first state. Because the three thread only sleep 200ms, in this patch sleep 120ms to enter the first state, the mistake is only 80ms, it is too short. In my laptop, I change 120ms to 190ms, the probability of reproduce this problem will be increased. > > So I think two way to solve this problem: (a) increased thread sleep time from 200ms to 1000ms (b) do not verify the first state. > > @jerqi @zuston how about you? There is a fix. https://github.com/apache/incubator-uniffle/pull/1023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
