[
https://issues.apache.org/jira/browse/UNOMI-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Serge Huber updated UNOMI-250:
------------------------------
Description:
Right now we have a bit of a mess in our services implementation sub-project.
All the service implementations are in the package:
org.apache.unomi.services.services
I propose that we rename this package to:
org.apache.unomi.services.impl
and that each service gets its own sub-package, for example the
RulesServiceImpl would be in:
org.apache.unomi.services.impl.rules
This would make it much easier to activate/deactivate logging per service
implementation, because currently it is tricky to get logging activated
properly unless using configuration by class. Having it by package would be a
lot better.
Utility classes such as ThirdPartyService or the clustering event classes would
also be moved with the service sub-package they belong to.
In terms of impact this should minimal, only people activating logs should be
notified that the class location has changed.
was:
Right now we have a bit of a mess in our services implementation sub-project.
All the service implementations are in the package:
org.apache.unomi.services.services
I propose that we rename this package to:
org.apache.unomi.services.impl
and that each service gets its own sub-package, for example the
RulesServiceImpl would be in:
org.apache.unomi.services.impl.rules
This would make it much easier to activate/deactivate logging per service
implementation, because currently it is tricky to get logging activated
properly unless using configuration by class. Having it by package would be a
lot better.
Utility classes such as ThirdPartyService or the clustering event classes would
also be moved with the service sub-package they belong to.
> Refactor services implementations into separate packages
> --------------------------------------------------------
>
> Key: UNOMI-250
> URL: https://issues.apache.org/jira/browse/UNOMI-250
> Project: Apache Unomi
> Issue Type: Bug
> Components: core
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Serge Huber
> Assignee: Serge Huber
> Priority: Major
> Fix For: 1.5.0
>
>
> Right now we have a bit of a mess in our services implementation sub-project.
> All the service implementations are in the package:
> org.apache.unomi.services.services
> I propose that we rename this package to:
> org.apache.unomi.services.impl
> and that each service gets its own sub-package, for example the
> RulesServiceImpl would be in:
> org.apache.unomi.services.impl.rules
> This would make it much easier to activate/deactivate logging per service
> implementation, because currently it is tricky to get logging activated
> properly unless using configuration by class. Having it by package would be a
> lot better.
> Utility classes such as ThirdPartyService or the clustering event classes
> would also be moved with the service sub-package they belong to.
> In terms of impact this should minimal, only people activating logs should be
> notified that the class location has changed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
