sergehuber commented on a change in pull request #147:
URL: https://github.com/apache/unomi/pull/147#discussion_r411213105
##########
File path:
extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
##########
@@ -19,23 +19,26 @@
var integration = require('@segment/analytics.js-integration');
var extend = require('extend');
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
+ .global('cxs')
.assumesPageview()
.readyOnLoad()
- .global('cxs')
.option('scope', 'systemscope')
.option('url', 'http://localhost:8181')
.option('timeoutInMilliseconds', 1500)
.option('sessionCookieName', 'unomiSessionId')
- .option('sessionId');
+ .option('sessionId'));
/**
* Initialize.
*
* @api public
*/
-Unomi.prototype.initialize = function(page) {
+Unomi.prototype.initialize = function() {
var self = this;
+
+ console.info('[UNOMI] Initializing...', arguments);
Review comment:
Javascript allows passing arguments to functions that don't declare
them. This log is here to check what the library is sending, as it has changed
over time and is expected to change again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
