giladw commented on a change in pull request #301:
URL: https://github.com/apache/unomi/pull/301#discussion_r637523624
##########
File path:
plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluator.java
##########
@@ -206,7 +206,7 @@ protected boolean isMatch(String op, Object actualValue,
String expectedValue, O
if (op == null) {
return false;
} else if (actualValue == null) {
- return op.equals("missing");
+ return op.equals("missing")|| op.equals("notIn") ||
op.equals("notEquals");
Review comment:
Thanks @jkevan
i dont think we can have both expectedValue=null && op=notEquals
like that:
{
"type": "profilePropertyCondition",
"parameterValues": {
"propertyName": "properties.countryCode",
"comparisonOperator": "notEquals",
"propertyValue": "null"
}
}
in such case we would use comparisonOperator=missing
{
"type": "profilePropertyCondition",
"parameterValues": {
"propertyName": "properties.countryCode",
"comparisonOperator": "missing"
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
