jkevan commented on a change in pull request #309:
URL: https://github.com/apache/unomi/pull/309#discussion_r662412180
##########
File path:
plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/actions/SetPropertyAction.java
##########
@@ -102,6 +102,12 @@ public int execute(Action action, Event event) {
propertyValue = format.format(date);
}
+ if (propertyValue != null && propertyValue.equals("eventArrivalTime"))
{
Review comment:
I would rename "eventArrivalTime" to "timeStamp" or
"actionExecutionTimeStamp" or "currentDate".
Because it's not really true that this timeStamp is the real event arrival
time. Event could arrive sooner and the action being executed few seconds after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
