jsinovassin commented on code in PR #581: URL: https://github.com/apache/unomi/pull/581#discussion_r1121935244
########## extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/services/impl/GroovyActionsServiceImpl.java: ########## @@ -70,41 +79,30 @@ public class GroovyActionsServiceImpl implements GroovyActionsService { private static final Logger logger = LoggerFactory.getLogger(GroovyActionsServiceImpl.class.getName()); private static final String BASE_SCRIPT_NAME = "BaseScript"; + private static final String GROOVY_SOURCE_CODE_ID_SUFFIX = "-groovySourceCode"; - public void setBundleContext(BundleContext bundleContext) { - this.bundleContext = bundleContext; - } - - @Reference private DefinitionsService definitionsService; - - @Reference private PersistenceService persistenceService; - - @Reference private SchedulerService schedulerService; - - @Reference private ActionExecutorDispatcher actionExecutorDispatcher; + private GroovyActionsServiceConfig config; - private Integer groovyActionsRefreshInterval = 1000; - + @Reference public void setDefinitionsService(DefinitionsService definitionsService) { this.definitionsService = definitionsService; } + @Reference public void setPersistenceService(PersistenceService persistenceService) { this.persistenceService = persistenceService; } - public void setGroovyActionsRefreshInterval(Integer groovyActionsRefreshInterval) { - this.groovyActionsRefreshInterval = groovyActionsRefreshInterval; - } - + @Reference() Review Comment: You can remove the parenthesis here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@unomi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org