(unomi) branch UNOMI-897-groovy-fixes updated: UNOMI-897 Fix issues reported by initial code review

[shuber]

This is an automated email from the ASF dual-hosted git repository.

shuber pushed a commit to branch UNOMI-897-groovy-fixes
in repository https://gitbox.apache.org/repos/asf/unomi.git


The following commit(s) were added to refs/heads/UNOMI-897-groovy-fixes by this 
push:
     new b129a070e UNOMI-897 Fix issues reported by initial code review
b129a070e is described below

commit b129a070ee81c095fb9727a69d7f18b38dbac235
Author: Serge Huber <shu...@jahia.com>
AuthorDate: Fri Jul 18 15:12:37 2025 +0200

    UNOMI-897 Fix issues reported by initial code review
---
 .../org/apache/unomi/groovy/actions/GroovyActionDispatcher.java   | 2 +-
 .../main/java/org/apache/unomi/groovy/actions/ScriptMetadata.java | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/GroovyActionDispatcher.java
 
b/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/GroovyActionDispatcher.java
index 224e87752..093a91d6f 100644
--- 
a/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/GroovyActionDispatcher.java
+++ 
b/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/GroovyActionDispatcher.java
@@ -79,7 +79,7 @@ public class GroovyActionDispatcher implements 
ActionDispatcher {
         }
         
         try {
-            Script script = scriptClass.newInstance();
+            Script script = scriptClass.getDeclaredConstructor().newInstance();
             setScriptVariables(script, action, event);
             
             return new MetricAdapter<Integer>(metricsService, 
this.getClass().getName() + ".action.groovy." + actionName) {
diff --git 
a/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/ScriptMetadata.java
 
b/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/ScriptMetadata.java
index 724dd9098..57b44e3ae 100644
--- 
a/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/ScriptMetadata.java
+++ 
b/extensions/groovy-actions/services/src/main/java/org/apache/unomi/groovy/actions/ScriptMetadata.java
@@ -41,7 +41,7 @@ public final class ScriptMetadata {
     private final String actionName;
     private final String scriptContent;
     private final String contentHash;
-    private final long lastModified;
+    private final long creationTime;
     private final Class<? extends Script> compiledClass;
     
     /**
@@ -66,7 +66,7 @@ public final class ScriptMetadata {
         this.actionName = actionName;
         this.scriptContent = scriptContent;
         this.contentHash = calculateHash(scriptContent);
-        this.lastModified = System.currentTimeMillis();
+        this.creationTime = System.currentTimeMillis();
         this.compiledClass = compiledClass;
     }
     
@@ -137,8 +137,8 @@ public final class ScriptMetadata {
      * 
      * @return creation timestamp in milliseconds since epoch
      */
-    public long getLastModified() { 
-        return lastModified; 
+    public long getCreationTime() { 
+        return creationTime; 
     }
     
     /**