Github user GERey commented on the pull request:
https://github.com/apache/usergrid/pull/517#issuecomment-217963801
Would totally agree if it wasn't for the following two issues:
1. People already have Integers in statistics. By not accounting for
Integers we force everybody who had notification statistics to not have access
without them doing a re-put of all afflicted data.
2. The endpoint you mentioned is also an issue, but not the one I tested
against. My main concern was with a UUID PUT with the payload. If you check my
test you can see it in more detail. It would skip the
NotificationService#postCollection and instead go through
org.apache.usergrid.services.AbstractCollectionService#putItemById.
The way I see it is that it is a bit ugly, but it stems from the fact that
we have a field that is required to be Long but we don't explicitly enforce
that on POST's or PUTs. The way we deal with this for regular entities is to
useobject maps because then we can use any type based on what the user wants.
Thats why I used objects above, but I can also agree that is really just a hack
until we do the aforementioned checking for all of our expected types.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
