[
https://issues.apache.org/jira/browse/USERGRID-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095213#comment-14095213
]
ASF GitHub Bot commented on USERGRID-207:
-----------------------------------------
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-usergrid/pull/44
USERGRID-207 Fix license headers in portal Angular.js files
Hi Folks,
OK, this PR proposes the following
* nests all Apache License headers within the root element of the HTML.
* correctly formats the html within all the files touched by the above
bullet format.
That is it.
I am still slightly puzzled as to why Angular cannot interpret a perfectly
legal HTML comment as such. Oh well... never mind. I may head over there if I
find the energy later on tonight.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/incubator-usergrid master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit efade6fc817974b2ab04fb7b7fa5ceb4695151f5
Author: Lewis John McGibbney <[email protected]>
Date: 2014-08-13T06:24:42Z
USERGRID-207 Fix license headers in portal Angular.js files
commit a945495062e0f93815c2b375a4d2f477ed70d793
Author: Lewis John McGibbney <[email protected]>
Date: 2014-08-13T06:39:01Z
USERGRID-207 Fix license headers in portal Angular.js files
----
> Fix license headers in portal Angular.js files
> -----------------------------------------------
>
> Key: USERGRID-207
> URL: https://issues.apache.org/jira/browse/USERGRID-207
> Project: Usergrid
> Issue Type: Story
> Components: Portal
> Affects Versions: 1.0
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Blocker
> Fix For: 1.0
>
>
> As reported here [0], it appears the commit to add licnese headers to all
> HTML files in the codebase broke some parsing behavhiour for Angular.js.
> The PR which is coming up fixes this for me locally as I now no longer have
> any errors or warnings when I debug thw portal code in the browser.
> [0]
> http://www.mail-archive.com/dev%40usergrid.incubator.apache.org/msg01345.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)
