Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/269#discussion_r31929564
--- Diff:
stack/services/src/main/java/org/apache/usergrid/services/notifications/impl/ApplicationQueueManagerImpl.java
---
@@ -175,13 +179,13 @@ public void queueNotification(final Notification
notification, final JobExecutio
//process up to 10 concurrently
Observable o = rx.Observable.create( new
IteratorObservable<Entity>( iterator ) )
- .flatMap( entity ->
Observable.just( entity ).map( entityListFunct )
-
.doOnError( throwable -> {
-
LOG.error( "Failed while writing",
-
throwable );
- }
).subscribeOn( Schedulers.io() )
+ .flatMap(entity ->
Observable.just(entity).map(entityListFunct)
+ .doOnError(throwable -> {
+ LOG.error("Failed while
writing",
+ throwable);
+ }).subscribeOn(Schedulers.io())
--- End diff --
Since we block on line 190, we won't need to subscribe on Schedulers.io().
I know you didn't add this, but can we remove it since we're spinning up
another thread that we don't need?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
