Github user tnine commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/282#discussion_r32443588
  
    --- Diff: 
stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/serialization/impl/MvccEntitySerializationStrategyV3Impl.java
 ---
    @@ -458,9 +460,9 @@ public ByteBuffer toByteBuffer( final EntityWrapper 
wrapper ) {
                 final Entity entity = wrapper.entity.get();
                 //Convert to internal entity map
                 final EntityMap entityMap = EntityMap.fromEntity( entity );
    -            final byte[] entityBytes;
    --- End diff --
    
    This still seems to use the fieldbuffer byte buffer.  Can we remove this 
completely and just use a nested JSON object?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to