Excellent, thanx for the update :). You must be getting tired of my trivial bug reports, but there are two tiny issues left: Aaron's removal of "KEY `predictivemoduleid` (`predictivemoduleid`)" left a trailing comma in vcl.sql:600 "KEY `IPaddress` (`IPaddress`)," which is preventing a successful import.
Also vcl.sql:2202 - a semicolon is missing at the end of the ALTER TABLE `semaphore`. -- Bostjan On Wed, Sep 24, 2014 at 6:13 PM, Josh Thompson <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Bostjan, > > Oops - sorry about that. vcl.sql and update-vcl.sql are updated now. I had > the changes in my working copy, but never committed them. > > Josh > > On Wednesday, September 24, 2014 5:49:15 PM Bostjan Boric wrote: >> Woohoo, that was a swift reply & fix alright :). Thanx for pointing out >> the update-vcl.sql script but neither this one nor the main vcl.sql seem >> to contain the vcl.semaphore definition. Judging by your getSemaphore() >> code the table definition hasn't changed since you last discussed it a year >> ago in the thread that you mention in your gigantic web code commit? >> (http://mail-archives.apache.org/mod_mbox/vcl-dev/201307.mbox/%3C2232243.J55 >> CAxcd2y@treebeard%3E) >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA1 >> > >> > Revision 1627322 fixes the loop problem when failing so that you don't get >> > email bombed if you are missing the semaphore table (or have some other >> > problem that would have resulted in abort getting called in a loop). >> > >> > Josh >> > >> > On Wednesday, September 24, 2014 8:57:46 AM Josh Thompson wrote: >> >> Bostjan, >> >> >> >> Yikes! Obviously, the code did not fail very well there. :( I'll look >> >> at >> >> making it fail without email bombing in the process. Thanks for jumping >> >> in >> >> to test the latest code. >> >> >> >> You can run the update-vcl.sql script (in the mysql directory) to add the >> >> necessary bits to the database. Something like this: >> >> >> >> mysql -h localhost -u root -p < update-vcl.sql >> >> >> >> You'll also need to add >> >> >> >> define("SEMTIMEOUT", "45"); >> >> >> >> to your conf.php file. >> >> >> >> Josh >> >> >> >> On Wednesday, September 24, 2014 1:44:28 AM Bostjan Boric wrote: >> >> > I decided to take the plunge and try to get fresh web code up & running >> >> > on a clean install of VCL but failed miserably - the prime issue being >> >> > the >> >> > missing semaphore table. Before even being able to sign in I was >> >> > greeted by a torrent of "An error has occurred. If this problem >> >> > persists, >> >> > please email...", with >> >> > utils.pm:871 if(ONLINEDEBUG && checkUserHasPerm('View Debug >> >> > Information')) >> >> > supressing any meaningful information - great for production >> >> > deployments, >> >> > not so great for testing :). The fun part: the statements in the "else" >> >> > clause of the above check actually managed to generate over 2000 >> >> > messages >> >> > (well, as long as it wasn't over 9000 ;)). I was sure the CentOS VM I >> >> > was >> >> > testing on wasn't running any MTAs. Turns out Postfix was running just >> >> > fine... And that I was testing with an old config.php that had >> >> > ERROREMAIL >> >> > set to my actual Gmail address... Google's still delivering the error >> >> > messages - 3 hours after I shut down the VM :P. That ought to teach me >> >> > a >> >> > lesson. >> >> > >> >> > In any case, I would be grateful if you could provide the necessary >> >> > table >> >> > creation statements for vcl.semaphore. >> >> > >> >> > Thanx in advance. Going back to cleaning up my inbox ;) >> >> > >> >> > > -----BEGIN PGP SIGNED MESSAGE----- >> >> > > Hash: SHA1 >> >> > > >> >> > > Andy, >> >> > > >> >> > > Dojo provides a way to "compile" the code to make load times faster. >> >> > > "Compiling" takes a list of source files, sticks them all together >> >> > > into >> >> > > a >> >> > > single file, removes unnecessary whitespace, and minimizes the length >> >> > > of >> >> > > variable names. All of this is done so that page loads are faster. >> >> > > Without compiling it, each file is loaded individually. VCL works >> >> > > fine >> >> > > without having the compiled versions. We didn't start "compiling" >> >> > > Dojo >> >> > > stuff until the 2.3 release. >> >> > > >> >> > > There are two modules we've created that extend Dojo functionality. >> >> > > They >> >> > > are in the web/js/vcldojo directory and have the necessary AFS header >> >> > > in >> >> > > them. >> >> > > >> >> > > I didn't think we needed the ASF header in the vcl*.js files since >> >> > > we're >> >> > > not modifying the code. However, I didn't think about the two >> >> > > modules >> >> > > we've created being compiled in. They are only in four of the >> >> > > vcl*.js >> >> > > files (2 compressed, 2 uncompressed - vclViewRequests.js and >> >> > > vclEditBlockAllocation.js + uncompressed versions). So, those would >> >> > > need >> >> > > the ASF header in them. I'm not sure if the other files should have >> >> > > it >> >> > > or not. >> >> > > >> >> > > I never commited the vcl*.js files to the repository since they are >> >> > > generated files. >> >> > > >> >> > > Josh >> >> > > >> >> > > On Monday, September 22, 2014 2:42:25 PM Andy Kurth wrote: >> >> > >> Thank you for this information. I knew we were shipping dojo with >> >> > >> the >> >> > >> release but was unaware the dojo directory had custom source code >> >> > >> under >> >> > >> it. >> >> > >> >> >> > >> What is different between stock dojo and dojo-1.6.2vcl? >> >> > >> >> >> > >> I see several files in dojo-1.6.2vcl such as the vcl*.js files. Is >> >> > >> this >> >> > >> code in the repository somewhere? >> >> > >> >> >> > >> I looked back at the 2.3.2 packaged release and the see VCL-specific >> >> > >> files >> >> > >> under the dojo directory were included. These do not include an ASF >> >> > >> header. Please address this for future releases. >> >> > >> >> >> > >> Thanks, >> >> > >> Andy >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> On Mon, Sep 15, 2014 at 10:50 AM, Josh Thompson >> >> > >> <[email protected]> >> >> > >> >> >> > >> wrote: >> >> > >> > -----BEGIN PGP SIGNED MESSAGE----- >> >> > >> > Hash: SHA1 >> >> > >> > >> >> > >> > As you may have seen, I did a rather large check in of the web >> >> > >> > code >> >> > >> > to >> >> > >> > trunk. >> >> > >> > Sorry for checking in so much at one time. I prefer not to check >> >> > >> > in >> >> > >> > that >> >> > >> > much >> >> > >> > together, but it included a rewrite of both the reservations pages >> >> > >> > and >> >> > >> > how >> >> > >> > all >> >> > >> > of the resources are handled. >> >> > >> > >> >> > >> > A few notable changes are that the New Reservation, Current >> >> > >> > Reservations, >> >> > >> > and >> >> > >> > the reserving part of Server Profiles pages have been combined >> >> > >> > into >> >> > >> > one >> >> > >> > page >> >> > >> > named Reservations. Also, all of the pages for managing resources >> >> > >> > have >> >> > >> > been >> >> > >> > rewritten to be more dynamic. The Computer Utilities page has >> >> > >> > been >> >> > >> > incorporated into the Edit Computer Profiles page. >> >> > >> > >> >> > >> > If anyone wants to try out trunk, after getting the code, you'll >> >> > >> > need >> >> > >> > to >> >> > >> > either use a stock distribution of Dojo Toolkit 1.6.2 (i.e. not >> >> > >> > one >> >> > >> > from a >> >> > >> > previous release) or download a custom compiled version from >> >> > >> > >> >> > >> > http://people.apache.org/~jfthomps/updates/dojo-1.6.2vcl.tar.gz >> >> > >> > >> >> > >> > Then, you'll need to go to the root directory of your web code and >> >> > >> > rename >> >> > >> > the >> >> > >> > existing dojo directory. Finally, untar the archive from above >> >> > >> > which >> >> > >> > will >> >> > >> > create a new dojo directory. >> >> > >> > >> >> > >> > You'll also need a copy of Spyc 0.5.1 from: >> >> > >> > >> >> > >> > https://github.com/mustangostang/spyc/releases >> >> > >> > >> >> > >> > Extract the archive under your .ht-inc directory. Spyc handles >> >> > >> > YAML >> >> > >> > data >> >> > >> > which may be stored in the variable table. >> >> > >> > >> >> > >> > Josh >> >> > >> > - -- >> >> > >> > - ------------------------------- >> >> > >> > Josh Thompson >> >> > >> > VCL Developer >> >> > >> > North Carolina State University >> >> > >> > >> >> > >> > my GPG/PGP key can be found at pgp.mit.edu >> >> > >> > >> >> > >> > All electronic mail messages in connection with State business >> >> > >> > which >> >> > >> > are sent to or received by this account are subject to the NC >> >> > >> > Public >> >> > >> > Records Law and may be disclosed to third parties. >> >> > >> > -----BEGIN PGP SIGNATURE----- >> >> > >> > Version: GnuPG v2.0.22 (GNU/Linux) >> >> > >> > >> >> > >> > iEYEARECAAYFAlQW/LIACgkQV/LQcNdtPQPWngCfYHLUNRukjX0ObwTQ1EUm6Ta3 >> >> > >> > BaQAmwZh2MVrv42ZtFoILeasxmqfOGsl >> >> > >> > =BQ2N >> >> > >> > -----END PGP SIGNATURE----- >> >> > > >> >> > > - -- >> >> > > - ------------------------------- >> >> > > Josh Thompson >> >> > > VCL Developer >> >> > > North Carolina State University >> >> > > >> >> > > my GPG/PGP key can be found at pgp.mit.edu >> >> > > >> >> > > All electronic mail messages in connection with State business which >> >> > > are sent to or received by this account are subject to the NC Public >> >> > > Records Law and may be disclosed to third parties. >> >> > > -----BEGIN PGP SIGNATURE----- >> >> > > Version: GnuPG v2.0.22 (GNU/Linux) >> >> > > >> >> > > iEYEARECAAYFAlQhyLIACgkQV/LQcNdtPQPQOgCeJgMZNWlgD1Tu3YwOqqgyTZpL >> >> > > av0An1ADq+GWYCjDFQJKL8MPSiHIPqBy >> >> > > =gI73 >> >> > > -----END PGP SIGNATURE----- >> >> >> >> -- >> >> ------------------------------- >> >> Josh Thompson >> >> VCL Developer >> >> North Carolina State University >> >> >> >> my GPG/PGP key can be found at pgp.mit.edu >> >> >> >> All electronic mail messages in connection with State business which >> >> are sent to or received by this account are subject to the NC Public >> >> Records Law and may be disclosed to third parties. >> > >> > - -- >> > - ------------------------------- >> > Josh Thompson >> > VCL Developer >> > North Carolina State University >> > >> > my GPG/PGP key can be found at pgp.mit.edu >> > >> > All electronic mail messages in connection with State business which >> > are sent to or received by this account are subject to the NC Public >> > Records Law and may be disclosed to third parties. >> > -----BEGIN PGP SIGNATURE----- >> > Version: GnuPG v2.0.22 (GNU/Linux) >> > >> > iEUEARECAAYFAlQizIIACgkQV/LQcNdtPQOMKACfUTsFVZcGMbbNrIS0DeYKQAuz >> > 2OIAljQBTR2AuJKoqkIWiGG7C1FPFHo= >> > =qMEd >> > -----END PGP SIGNATURE----- > - -- > - ------------------------------- > Josh Thompson > VCL Developer > North Carolina State University > > my GPG/PGP key can be found at pgp.mit.edu > > All electronic mail messages in connection with State business which > are sent to or received by this account are subject to the NC Public > Records Law and may be disclosed to third parties. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > > iEYEARECAAYFAlQi7aoACgkQV/LQcNdtPQOmDQCdGCSanPr4jMqt9kNOglsN3L1c > beMAmwWVfOELLFnGD8fuYbUcYW9TWg5e > =BX2U > -----END PGP SIGNATURE----- >
