[ 
https://issues.apache.org/jira/browse/VCL-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176918#comment-14176918
 ] 

ASF subversion and git services commented on VCL-794:
-----------------------------------------------------

Commit 1633161 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1633161 ]

VCL-794
Added a warning message and return statement in 
new.pm::computer_not_being_used. This is reached if the attempt loop exhausts 
all attempts. It had not been explicitly returning a value if this case was 
reached.

Added an extra loop iteration in computer_not_being_used if it detects a 
competing process had successfully finished loading the correct image during 
the last iteration of checking the loop. This gives it one more chance.

Other
Made minor changes to notify statements in update_request_state and 
get_request_current_state_name in utils.pm.

> Make sure computer_not_being_used in new.pm always returns an explicit value
> ----------------------------------------------------------------------------
>
>                 Key: VCL-794
>                 URL: https://issues.apache.org/jira/browse/VCL-794
>             Project: VCL
>          Issue Type: Bug
>          Components: vcld (backend)
>    Affects Versions: 2.3.2
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>            Priority: Minor
>             Fix For: 2.4
>
>
> There is a case where new.pm::computer_not_being_used exhausts all attempts 
> in its _ATTEMPT: for (my $attempt..._ loop but does not return an explicit 
> value after the loop is exited.  There is no code after the loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to