[
https://issues.apache.org/jira/browse/VCL-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209851#comment-14209851
]
ASF subversion and git services commented on VCL-682:
-----------------------------------------------------
Commit 1639353 from [~fapeeler] in branch 'vcl/trunk'
[ https://svn.apache.org/r1639353 ]
VCL-682
cleanup of older xCAT provisioning entries
> Consolidate xCAT provisioning modules, retire xCAT 1.x support
> --------------------------------------------------------------
>
> Key: VCL-682
> URL: https://issues.apache.org/jira/browse/VCL-682
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Affects Versions: 2.3
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Priority: Minor
> Fix For: 2.4
>
>
> There are currently 3 different xCAT*.pm modules:
> xCAT.pm - Supposed to be the base module, supports xCAT 1.3
> xCAT2.pm - Contains latest xCAT 2.x code. Supports some xCAT 2.x versions.
> xCAT21.pm - Older xCAT 2.x module.
> There are several duplicated subroutines in each module. It appears as if
> subroutines were copied directly from xCAT.pm when the xCAT2*.pm modules were
> initially created. This shouldn't have been done. They inherit from xCAT.pm
> and should use the same subroutines if the subs are the same.
> I'd like to end support for xCAT 1.x. Anyone still running it should
> upgrade. If support is ended it will be much easier to clean up all of the
> xCAT code into a single modue. I propose the following:
> -Remove all code from xCAT.pm which is 1.x specific. There are some
> subroutines which attempt to call utilities which haven't existed in xCAT for
> some time.
> -Move the duplicated subroutines from xCAT2.pm back into xCAT.pm, overwriting
> them.
> -Perform a major cleanup of the existing code. Update it to use newer
> functions such as $self->mn_os->execute. There are many places in the
> existing code where commands are run on the management node using <COMMAND>,
> the output may be null, but is checked anywhere generating an error.
> For the version the changes are released in, the database files will need to
> be updated so that the xCAT2* provisioning modules call xCAT.pm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)