[
https://issues.apache.org/jira/browse/VCL-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693822#comment-14693822
]
ASF subversion and git services commented on VCL-897:
-----------------------------------------------------
Commit 1695575 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1695575 ]
VCL-897
Updated Windows.pm::create_user to use the add_user_to_group subroutine instead
of using concatenating its own command for consistency. Removed
grant_connect_method_access and grant_root_access subroutines. All they were
doing is calling add_user_to_group.
Updated text in notify messages in Windows.pm: user_exists, add_user_to_group
> Simplify arguments accepted by grant_root_access subroutines
> ------------------------------------------------------------
>
> Key: VCL-897
> URL: https://issues.apache.org/jira/browse/VCL-897
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Fix For: 2.5
>
>
> The {{grant_root_access}} subroutines in {{Linux.pm}} and {{Windows.pm}}
> accept a hash reference argument which must contain a _username_ key. The
> username is the only piece of information {{grant_root_access}} needs.
> {{grant_root_access}} is also currently using a _root\_access_ key. It makes
> no sense to call this subroutine and then have it check if it should have
> been called in the first place. The caller should be responsible for this.
> The hash reference argument was presumably a result of copying and pasting
> the arguments accepted by its caller, the {{create_user}} subroutine which
> requires the other pieces of information contained in the hash reference.
> There is no point of passing information to {{grant_root_access}} which it
> doesn't need. It would be better programming style to pass it a simple
> string containing the username.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
