[
https://issues.apache.org/jira/browse/VCL-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351972#comment-15351972
]
ASF subversion and git services commented on VCL-956:
-----------------------------------------------------
Commit 1750422 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1750422 ]
VCL-807 - indicate timezone on schedules / reservations
VCL-956 - display reservation times in user's own timezone
blockallocations.php:
-modified blockAllocationForm: added hidden input fields containing a timestamp
of the current time on the server and the short code for the timezone of the
server; added timezone short code after input fields where dates or times are
input or displayed
-modified getCurrentBlockHTML: modified nextstart for listed block allocations
to have the user's local timezone; added a hidden input field containing the
short code for the timezone of the server
-modified viewBlockStatus: added the server's timezone to the start and end
time of the block allocation
-modified viewBlockAllocatedMachines: added line containing short code of
server's timezone and stating all listed times are in that timezone
dashboard.php: modified dashboard: added line containing short code of server's
timezone and stating all listed dates and times are in that timezone
privileges.php: modified userLookup: added short code of server's timezone to
login times; added short code of server's timezone to reservation start/end
times
requests.php:
-modified viewRequests: added a block at the top that gets the timezone offset
of the user's browser, submits it back as a GET request, and saves it in a
session variable
-modified newReservationHTML: add tzoffset to time used to generate drop down
values for selecting start time; removed timezone short code of server
displayed next to the start time
-modified AJshowRequestSuggestedTimes: added tzoffset to start time of time
slots; changed reference in foreach loop from $slot['startts'] to
$slots[$key]['startts']
-modified AJeditRequest: generate date/time values for displaying and for forms
that are in the user's timezone
-modified AJsubmitEditRequest: convert submitted start/end times from user
timezone to server timezone
-modified getReserveDayData: add tzoffset to time when generating list of days
for start select input
schedule.php: modified addEditDialogHTML: added timezone short code next to
start/end input times; added a hidden input field containing the short code for
the timezone of the server
states.php: added AJsetTZoffset
statistics.php: modified viewStatistics: added line containing short code of
server's timezone and stating all listed dates and times are in that timezone
utils.php:
-modified setupSession: added persistdata to $_SESSION
-modified showTimeTable: added tzoffset to date/time labels to show in user's
timezone
-modified prettyDatetime: added tzoffset to $stamp before formatting date/time
-added AJsetTZoffset
-modified getDojoHTML: added global javascript variable tzoffset that is set to
$_SESSION['persistdata']['tzoffset'], or if that is not yet set, to 'unset'.
also added timeout to call init() which uses AJAX to send the user time zone
offset to the server that can get set in the session variable; this is to
attempt to get tzoffset set in the session as soon as possible after a user
visits the site
vm.php:
-modified vmhostdata: add timezone short code to times displayed for when VMs
will be removed from hosts
-modified AJvmFromHost: add timezone short code to times displayed for
confirming when VMs will be removed from hosts
blockallocations.js:
-modified blockFormAddListSlot: use now timestamp embedded in hidden field in
page instead of current time in browser for validating submitted date so that
it will be in the server's timezone
-modified gridDateTimePrimary, gridTimePrimary, timeFromTextBox,
blockTimesGridStart, and blockTimesGridEnd: added timezone short code from
embedded hidden field to returned date/time
code.js:
-added init() which is used to do any page initialization, but currently only
sends the user's timezone offset via AJAX if it is not already set
-added getDayName function to Date object
requests.js:
-modified getDeployData: add user's timezone offset to value that gets put in
data.start
-modified useSuggestedEditSlot: modified for loop that finds matching day of
start day select input to compare by the day string instead of by the value of
the select input
resources/schedule.js: modified getTime: added timezone short code from
embedded hidden input field to returned string
> display reservation times in user's own timezone
> ------------------------------------------------
>
> Key: VCL-956
> URL: https://issues.apache.org/jira/browse/VCL-956
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Fix For: 2.5
>
>
> Reservation times should be displayed in the user's own timezone rather than
> the server's time zone. There is also a bug related to this where javascript
> is used to check the selected start time before submitting a reservation.
> This can prevent a users from submitting reservations for certain times when
> they are in different timezones from the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
