[
https://issues.apache.org/jira/browse/VCL-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353480#comment-15353480
]
ASF subversion and git services commented on VCL-953:
-----------------------------------------------------
Commit 1750551 from [email protected] in branch 'vcl/trunk'
[ https://svn.apache.org/r1750551 ]
VCL-953
Added subroutines:
Module.pm::get_class_variable_hierarchy
utils.pm::wrap_string
Linux.pm::start_network_interface
Linux.pm::stop_network_interface
Linux.pm::delete_default_gateway
Linux.pm::set_default_gateway
Linux.pm::clear_file
Linux.pm::update_resolv_conf
Reworked Linux.pm::get_exclude_list. Added code to allow for * wildcards in the
list entries. Added:
Linux.pm::get_exclude_regex_list
Linux.pm::is_file_in_exclude_list
Rewrote Linux.pm::generate_exclude_list_sample to explain the wildcard feature.
It was also a mess.
Rewrote Ubuntu.pm::enable_dhcp and set_static_public_address. It was clobbering
the /etc/network/interfaces file if an image had been configured with anything
other that the default interface configuration such as setting up bridge.
Rewrote Linux.pm::clean_known_files. Added $CAPTURE_DELETE_FILE_PATHS and
$CAPTURE_CLEAR_FILE_PATHS class variables to Linux.pm and Ubuntu.pm. These are
array references which list files to clear or delete.
VCL-957
Added command to set the root password in Linux.pm::pre_capture. It's currently
using the $WINDOWS_ROOT_PASSWORD variable name but that's fine for now.
Other
Removed call to process_connect_methods from Linux.pm::pre_capture. It wasn't
doing anything other than generate warning messages.
Added optional $display_output argument to Linux.pm::file_exists. This is used
from Linux.pm::delete_file to reduce vcld.log messages.
Added command to delete /etc/ssh/external_sshd_config in
Linux.pm::delete_service when the ext_sshd service is deleted. This file was
getting left.
Removed useless/sloppy code in Ubuntu.pm::clean_iptables. Set this subroutine
to always return 1. All it had been doing was displaying a warning when it
detected the iptables service didn't exist.
> Ubuntu.pm clobbers /etc/network/interfaces even if listed in vcl_exclude_list
> -----------------------------------------------------------------------------
>
> Key: VCL-953
> URL: https://issues.apache.org/jira/browse/VCL-953
> Project: VCL
> Issue Type: Bug
> Components: vcld (backend)
> Affects Versions: 2.4.2
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Fix For: 2.5
>
>
> There are several places in Ubuntu.pm which may alter the
> /etc/network/interfaces on the computer being loaded or captured which are
> not checking if it is listed in /root/.vclcontrol/vcl_exclude_list.
> I came across this while attempting to capture an Ubuntu KVM image which had
> bridges configured in the interfaces file. The capture process mangled the
> file causing the image's network to not come up when loaded.
> We'll need to figure out how to address this since some subroutines really
> need to alter the file, such as when setting a static IP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
