[
https://issues.apache.org/jira/browse/VCL-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634034#comment-15634034
]
ASF subversion and git services commented on VCL-1001:
------------------------------------------------------
Commit 1767960 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1767960 ]
VCL-1001 - changing a future reservation to a now reservation doesn't properly
update the reserved computer
requests.php: modified AJsubmitEditRequest: added code to determine if old
start time was in the future or not and pass 'now' or 'future' to updateRequest
accordingly
utils.php: modified updateRequest: added additional argument $nowfuture and
removed code that determined if the reservation was now or future based on the
reservation start time - the problem was that if a future reservation got
changed to a now reservation, the isAvailable could have changed the
computerid, but nowfuture was determined to be now and then the 2nd half of the
function where the computerid is updated was skipped; so the user ended up with
a reservation on the same computer they had, which may or may not have another
reservation on it
xmlrpcWrappers.php: updated XMLRPCextendRequest and XMLRPCsetRequestEnding:
added 'now' to call to updateRequest
> changing a future reservation to a now reservation doesn't properly update
> the reserved computer
> ------------------------------------------------------------------------------------------------
>
> Key: VCL-1001
> URL: https://issues.apache.org/jira/browse/VCL-1001
> Project: VCL
> Issue Type: Bug
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Fix For: 2.5
>
>
> If a user has a reservation for a computer that is in the future and then
> changes the reservation so that the start time is in the past, making it a
> "now" reservation, the code that updates which computer is assigned to the
> user gets skipped. Fortunately, the backend catches that the computer is
> inuse and fails the reservation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
