[
https://issues.apache.org/jira/browse/VCL-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832203#comment-15832203
]
ASF subversion and git services commented on VCL-1006:
------------------------------------------------------
Commit 1779664 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1779664 ]
VCL-1006 - performance improvements for 2.5
privileges.php:
-added conditionals to skip configAdmin user privilege in several places in
these functions: viewNodes, selectNode, and getUserPrivRowHTML
-changed uses of array_key_exists to isset in these functions:
printUserPrivRow, getUserPrivRowHTML, getResourcePrivRowHTML,
getNodePrivileges, getNodeCascadePrivileges, AJchangeUserPrivs,
AJchangeUserGroupPrivs, AJsubmitAddUserGroupPriv, and AJsubmitAddResourcePriv
-reverted a few places that were mistakingly changed from in_array to isset in
these functions: AJchangeResourcePrivs, AJsubmitAddUserPriv,
AJsubmitAddUserGroupPriv, AJsubmitAddResourcePriv, and checkUserHasPriv
-modified AJchangeResourcePrivs: fixed issue preventing setting a resource
attribute at a node where the same attribute was being blocked from being
cascaded down
xmlrpcWrappers.php:
-changed uses of array_key_exists to isset in XMLRPCgetResourceGroupPrivs and
_XMLRPCchangeResourceGroupPriv_sub
utils.php:
-removed places where subarrays were created by calling array() in these
functions since it is unnecessary: getImages, getChildNodes,
getResourceGroupMemberships, getResourceGroupMembers, findAvailableTimes
-changed uses of array_key_exists to isset in these functions: getImages,
getServerProfiles, getServerProfileImages, getImageConnectMethods,
getImageConnectMethodTexts, getProductionRevisionid, removeNoCheckout,
getUserResources, getUserResourcesUp, addNodeUserResourcePrivs,
addOwnedResources, addOwnedResourceGroups, getParentNodes, getChildNodes,
getUserGroups, getResourceGroupMembers, getUserUnityID, checkUserHasPerm,
findAvailableTimes, selectInputHTML, prettyDatetime, getMaintItemsForTimeTable,
getNodeInfo, and sortKeepIndex
-changed uses of foreach(array_keys(...) as $) to foreach(... as $ => $tmp) in
these functions: getUserResourcesDown, addNodeUserResourcePrivs
-modified getImageConnectMethods: split query to get all methods from a single
query to a temporary table with 3 individual queries due to slowness caused by
the OR's in the conditional of the "LEFT JOIN connectmethodmap"
> performance improvements for 2.5
> --------------------------------
>
> Key: VCL-1006
> URL: https://issues.apache.org/jira/browse/VCL-1006
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Fix For: 2.5
>
>
> This issue is to track performance improvements to the web code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
