[
https://issues.apache.org/jira/browse/VCL-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025218#comment-16025218
]
ASF subversion and git services commented on VCL-887:
-----------------------------------------------------
Commit 1796182 from [email protected] in branch 'vcl/trunk'
[ https://svn.apache.org/r1796182 ]
VCL-1051
Added checks in State.pm::state_exit for checkpoint state.
Removed condition that prevented the request state from being updated to
'complete' if current request state is 'deleted' and the new request state is
anything other than 'complete'. If state_exit got called during the 'deleted'
state with arguments set to 'failed', the request state would be left in
'pending' when the process ended.
VCL-887
Changed call in new.pm::process from switch_state to state_exit.
Removed no longer used utils.pm::switch_state subroutine.
Removed unused $self->data->get_* variables from new.pm.
Other
Removed unreachable call to exit; in reclaim.pm.
> Clean up backend code
> ---------------------
>
> Key: VCL-887
> URL: https://issues.apache.org/jira/browse/VCL-887
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Fix For: 2.5
>
>
> Nearly all of the backend code is consistently formatted. For example:
> {code}
> if ($foo) {
> notify($ERRORS{'OK'}, 0, "some useful message");
> }
> else {
> notify($ERRORS{'WARNING'}, 0, "some useful warning");
> }
> {code}
> There is a space between _if_ and the opening parenthesis and another between
> the closing parenthesis and opening curly bracket. Compare it to:
> {code}
> if(!defined($du_output)) {
> notify($ERRORS{'WARNING'}, 0, "failed to execute command du command to if
> image $image_name exists");
> return;
> }
> {code}
> Where's the space? What does the message mean?
> Granted, the space issues are trivial. The nonsensical _notify_ message is a
> bit more of a problem.
> Perhaps we should create a script to analyze the code or even add a hidden
> option to _vcld_ to analyze itself. Committers could run it before
> committing to check for any accidental inconsistencies. We could add a step
> to the release procedures to run the script and check for inconsistencies.
> This issue will be used to track all of the code cleanup and of the
> development of any automated methods created to address this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
