[ 
https://issues.apache.org/jira/browse/VCL-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096626#comment-16096626
 ] 

ASF subversion and git services commented on VCL-1055:
------------------------------------------------------

Commit 1802628 from [email protected] in branch 'vcl/trunk'
[ https://svn.apache.org/r1802628 ]

VCL-1055
Added check in Linux.pm::set_static_default_gateway to ensure value returned 
from get_public_default_gateway() is defined before comparing it to avoid 
uninitialized warnings in vcld.log.

> 'Use of uninitialized value in lc' warning may be generated from a few 
> subroutines
> ----------------------------------------------------------------------------------
>
>                 Key: VCL-1055
>                 URL: https://issues.apache.org/jira/browse/VCL-1055
>             Project: VCL
>          Issue Type: Bug
>          Components: vcld (backend)
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>             Fix For: 2.5
>
>
> There are a few subroutines calling:
> {code}my $network_type = lc(shift()) || 'public';{code}
> If an argument isn't specified, the following warning is generated:
> {noformat}
> |8075|16|16|reinstall|vcld:warning_handler|646| ---- WARNING ----
> |8075|16|16|reinstall|vcld:warning_handler|646| 2017-06-23 
> 12:50:10|8075|16|16|reinstall|vcld:warning_handler|646|Use of uninitialized 
> value in lc at /usr/local/vcl-2.5-RC1/bin/../lib/VCL/Module/OS.pm line 2641.
> |8075|16|16|reinstall|vcld:warning_handler|646| ( 0) vcld, warning_handler 
> (line: 646)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-1) OS.pm, 
> get_default_gateway (line: 2641)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-2) OS.pm, 
> update_public_ip_address (line: 1515)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-3) OS.pm, reserve (line: 
> 221)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-4) Windows.pm, reserve 
> (line: 1045)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-5) new.pm, reserve_computer 
> (line: 875)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-6) new.pm, process (line: 
> 381)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-7) vcld, make_new_child 
> (line: 601)
> |8075|16|16|reinstall|vcld:warning_handler|646| (-8) vcld, main (line: 353)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to