[ 
https://issues.apache.org/jira/browse/VCL-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822298#comment-17822298
 ] 

ASF subversion and git services commented on VCL-1148:
------------------------------------------------------

Commit 05627d2159d60744e162b90a3c4325bea66ec20d in vcl's branch 
refs/heads/develop from Josh Thompson
[ https://gitbox.apache.org/repos/asf?p=vcl.git;h=05627d21 ]

VCL-1148 - siteconfig - handle mariadb update query returning -1 when row 
successfully updated

siteconfig.php:
-added fixAffectedRowsRC
-modified AJaddAffiliationSetting: added btn to data returned in AJAX error 
when invalid $affilid passed in
-modified AffilHelpAddress->setValue: added call to fixAffectedRowsRC after $rc 
= mysqli_affected_rows
-modified AffilHelpAddress->deleteValue: added call to fixAffectedRowsRC after 
$rc = mysqli_affected_rows
-modified AffilWebAddress->__construct: small change to $constraints
-modified AffilWebAddress->setValue: added call to fixAffectedRowsRC after $rc 
= mysqli_affected_rows
-modified AffilWebAddress->deleteValue: added call to fixAffectedRowsRC after 
$rc = mysqli_affected_rows
-modified AffilKMSserver->setValue: added call to fixAffectedRowsRC after $rc = 
mysqli_affected_rows
-modified AffilKMSserver->deleteValue: added code similar to fixAffectedRowsRC 
specific to this function
-modified AffilTheme->setValue: added call to fixAffectedRowsRC after $rc = 
mysqli_affected_rows
-modified AffilTheme->deleteValue: added call to fixAffectedRowsRC after $rc = 
mysqli_affected_rows
-modified AffilShibOnly->setValue: added call to fixAffectedRowsRC after $rc = 
mysqli_affected_rows
-modified AffilShibName->setValue: added call to fixAffectedRowsRC after $rc = 
mysqli_affected_rows
-modified AffilShibName->deleteValue: added call to fixAffectedRowsRC after $rc 
= mysqli_affected_rows


> siteconfig - handle mariadb update query returning -1 when row successfully 
> updated
> -----------------------------------------------------------------------------------
>
>                 Key: VCL-1148
>                 URL: https://issues.apache.org/jira/browse/VCL-1148
>             Project: VCL
>          Issue Type: Improvement
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>            Assignee: Josh Thompson
>            Priority: Minor
>             Fix For: 2.6
>
>
> During testing, it was found that there are times mariadb will return -1 when 
> a row is updated and there is no error when the documentation says it should 
> return true or set an error that can be obtained with mysqli_errno. This case 
> needs to be corrected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to