[
https://issues.apache.org/jira/browse/VELOCITY-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467030
]
Henning Schmiedehausen commented on VELOCITY-191:
-------------------------------------------------
Due to current weather conditions over here I am in the home office and have
time to get it in as a really, really latecomer. Thank Will and Nathan for
lobbying this on the mailing list. ;-)
* You actually have a long standing bug in there. Your test for UTF-16LE
should be after UTF-32LE, because if the first two bytes are a match,
then the latter is never used.
* This is a good case for unit tests. Patches without Unit tests are not good
(TM). :-)
* I've rewritten that a bit to make it more readable and also the function of
skipBOM better understandable.
> UnicodeFileResourceLoader for Win2k Notepad UTF-8 files
> -------------------------------------------------------
>
> Key: VELOCITY-191
> URL: https://issues.apache.org/jira/browse/VELOCITY-191
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.3.1
> Environment: Operating System: All
> Platform: All
> Reporter: Mailmur
> Assigned To: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.5
>
> Attachments: FileResourceLoader-UnicodeStream.zip
>
>
> [copypaste from velocity-user mailing list]
> Date: Mon, 14 Jul 2003 01:52:11 -0700 (PDT)
> From: mailmur <[EMAIL PROTECTED]>
> Subject: UnicodeFileResourceLoader to support Win2k Notepad UTF-8 files
> Content-Type: text/plain; charset=us-ascii
> I discovered, that files saved with Win2k Notepad UTF-8 format always
> generated
> an extra ? character at the start of ISO-8859-1 output text.
> This was due to lack of UTF8 BOM mark support in
> InputStreamReader/OutputStreamWriter classes.
> I then created a inputstream implementation to skip BOM mark to overcome this
> bug.
> Please, find here a source + testprogram to see it for yourself. I created
> UnicodeFileResourceLoader to make all this transparent.
> http://koti.mbnet.fi/akini/java/unicodereader/
> I dont know what is the proper procedure to add this to Velocity core (if you
> find this useful), but here it is. Feel free to change class package. Or is
> this even the right list to announce such addition....
> Here is a link to Sun bugparade about the UTF-8 BOM problem:
> http://developer.java.sun.com/developer/bugParade/bugs/4508058.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
