Lei, Thanks so much for submitting this.
Can I ask you to do a little more work please? It's easiest for us if you attach this in "patch" format to the actual JIRA account. That way we can track it easily and also see exactly what the changes are. (Stuff gets lost easily on the mailing list). If you haven't done this before, it's really pretty easy. (1) Create an account on http://issues.apache.org/JIRA (2) Create a patch in unified diff format. If you've downloaded the code from subversion, go to the root of the velocity directory and type svn diff > patch-223.txt If you don't have the latest checkedout code from subversion do mkdir velocity cd velocity svn checkout http://svn.apache.org/repos/asf/velocity/engine/trunk . (make your changes) svn diff > patch-223.txt (3) Go to the JIRA issue, enter "attach file" and attach the patch file (4) Please also add a note with the detailed explanation you gave in your email. For the other issue, you can "report new issue" and attach your patch to that. Thanks again! WILL On 3/31/07, Lei Gu <[EMAIL PROTECTED]> wrote:
Hi Will, Here are fixes for issue 223 only. Issue number 223, Velocity Engine uses excessive amount of memory when a large number of directives and macros are used. When a macro or directive is used, they are parsed at run time and the same macro will be parsed every time it is invoked from another macro. This results in an explosion of the duplicated string images. We introduce a string image pool. Before a string image is returned from VelocityCharStream GetImage method, we simply checks against the string image pool. If the string image exists in the pool, we will return the image from the pool. Otherwise we simply return the image itself. We observe a 30% memory footprint reduction after this. http://www.nabble.com/file/7592/StringImagePool.java StringImagePool.java http://www.nabble.com/file/7590/VelocityCharStream-patch.txt VelocityCharStrea http://www.nabble.com/file/7591/VelocityCharStream.java VelocityCharStream.java m-patch.txt Thanks. -- Lei -- View this message in context: http://www.nabble.com/Fixes-for-issue-223-only---resubmitted-tf3497189.html#a9768129 Sent from the Velocity - Dev mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Forio Business Simulations Will Glass-Husain [EMAIL PROTECTED] www.forio.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
