[
https://issues.apache.org/jira/browse/VELOCITY-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613178#action_12613178
]
Will Glass-Husain commented on VELOCITY-570:
--------------------------------------------
Hi --
I took a look at this older issue. Jacob-- it looks like your patch doesn't
accomplish anything. VelocityCharStream is always init''d with a buffer size
of 4096 as the constructor and ReInit that's called doesn't specify a buffer
size. Can you take another look?
As a side note, there's a bug in the class here
public void ReInit(java.io.InputStream dstream, int startline,
int startcolumn, int buffersize)
{
ReInit(new java.io.InputStreamReader(dstream), startline, startcolumn,
4096);
}
should be
public void ReInit(java.io.InputStream dstream, int startline,
int startcolumn, int buffersize)
{
ReInit(new java.io.InputStreamReader(dstream), startline,
startcolumn,buffersize);
}
I fixed this, but it's not really relevant since the constructor is never
called.
> speed improvement of the tokenizer
> ----------------------------------
>
> Key: VELOCITY-570
> URL: https://issues.apache.org/jira/browse/VELOCITY-570
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.4, 1.5, 1.6
> Environment: Tested on FreeBSD 6.2-STABLE and Linux (Debian Etch) on
> i386.
> Java: JDK 1.5
> Reporter: Ronald Klop
> Fix For: 1.6
>
> Attachments: expandbuff-speedup-reinit-fix.patch,
> expandbuff-speedup.patch
>
>
> On some large templates (1-4MB) velocity gets very slow. I used JProfiler and
> found a lot of time is spent in VelocityCharStream.ExpandBuff. It is doing a
> lot of System.arraycopy.
> The problem is that the size of the buffer is increased linearly in stead of
> exponentialy.
> I have made a patch which doubles the size of the buffer in stead of
> incrementing it with the same value.
> In my tests and in JProfiler it is shown that a lot less time is spent in
> ExpandBuff.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
