[ 
https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666434#action_12666434
 ] 

byronvf edited comment on VELOCITY-680 at 1/22/09 11:20 PM:
-----------------------------------------------------------------

What are some thoughts on making this #global instead of #local such that 
global vars are set instead of locals? I think it is far more likely that a 
developer intends assignments in a macro to be local by default then global. 
you don't have to look far into the language world to see this is the trend.  
#global is needed for the  'velocimacro.context.localscope=true' property 
(Which I think should be the default anyway)



      was (Author: byronvf):
    What are some thoughts on making this #global instead of #local such that 
global vars are set instead of locals? I think it is far more likely that a 
developer intends assignments in a macro to be local by default then global. 
you don't have to look far into the language world to see this is the trend.  
#global is needed for the  
'velocimacro.permissions.allow.inline.local.scope=true' property (Which I think 
should be the default anyway)


  
> RFC: New #local directive that behaves like #set but puts things into local 
> context in macro rendering
> ------------------------------------------------------------------------------------------------------
>
>                 Key: VELOCITY-680
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-680
>             Project: Velocity
>          Issue Type: New Feature
>    Affects Versions: 1.7
>            Reporter: Jarkko Viinamäki
>         Attachments: velocity-local-directive.patch
>
>
> It would be very useful to be able to set variables that are in local macro 
> scope. That is, they do not overwrite "global" variables and are thrown away 
> after macro rendering. This would allow people to build macro libraries that 
> do not clash so easily with each other.
> There is some implementation of a "LocalDirective" in 
> experimental/localdirective but I didn't quite get it and it doesn't follow 
> the same syntax as #set. I used a few minutes to hack together this 
> alternative implementation which behaves exactly like #set but it puts things 
> in local context only.
> There's only one test case since this is Request-for-Comments type of patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to