Nathan, On 11/26/14 4:55 PM, Nathan Bubna wrote: > On Wed, Nov 26, 2014 at 1:41 PM, Christopher Schultz < > ch...@christopherschultz.net> wrote: > ... > >> If all logging could be replaced by using commons-logging, then all will >> be well. commons-logging is just a pass-through for whatever logger is >> really being used... log4j, slf4j, java.util.logging, etc. Most ASF >> projects use it already as the logging framework just to make things >> easier for everyone. It's super lightweight and nobody has to fight over >> which logging framework is best since it plugs into all of them. >> > > I'm ok with either. Whoever wants to do the work can pick, AFAIC.
Agreed. I'm certainly not motivated to rip-out any logging in 1.x, but 2.x seems ripe for such things if they haven't already happened. I think 1.x still uses Avalon, which has been abandoned (right?). >> I seem to recall having a bear of a time building the 2.x branch, but my >> Maven-fu is not strong. I admit having a fear of Maven because I don't >> understand how it works and prefer Ant's ability to do exactly what I >> tell it to do, instead of what it thinks is best for me ;) > > The only thing you have to fear is fear itself. And dependency hell, of > course. Yes. And builds that take way longer than necessary. One of our projects at $work uses Maven to build and that part of the build (which represents maybe 5% of the total Java code to compile) takes roughly 90% of the build time of the rest of the code, not including actually fetching those dependencies. :( >> I'm interested to hear about the fixes to the core library, though, and >> the unit tests that weren't being invoked and that were failing. Perhaps >> there is a reason they had been avoided. If there are legitimate fixes >> available from Frederick, we should be looking at those primarily, >> especially from a potential back-porting perspective. That is, if 1.7 is >> in fact broken, let's fix it. >> > > As long as 1.x stays relatively stable, fixes for it are a great thing. +1 My feeling is that 1.x is totally in maintenance mode: we should only be fixing things that are actually broken. New features, etc. should all go into 2.x. -chris
signature.asc
Description: OpenPGP digital signature