Am 2019-02-23 um 00:40 schrieb Claude Brisson:
Hi all.

The VELOCITY-892 branch contains a fix for the corresponding issue [1].

The purpose is to let the method arguments conversion handler manipulate the formal arguments types as java.lang.reflect.Type rather than java.lang.Class, so that when dealing with a method like

   void foo(List<Integer> list)

called with a string like "1,2,3", the conversion handler can choose the correct converter between several string->list converters.

But merging the VELOCITY-892 branch back to trunk requires a minimal jdk version of 1.8 (because of the Type.getTypeName() method).

Java SE 8 is now five years old, so I don't think it's a problem.

Any objection?

I think it is absolutely not our task to split strings for user's convenience. The next one will request another separator and so on. We should add at most a splitter tool. What we could do is to provide a new syntax: "$obj.foo([1,2,3,4,5])", but that is another story and out of my knowledge

As for Java 8, don't do if you don't have a compelling reaons, i.e., rewriting most of the codebase to use Java 8 features. We yet event didn't move to generics in some places.

Michael


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Reply via email to