[
https://issues.apache.org/jira/browse/VELOCITY-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995447#comment-16995447
]
Thomas Mortagne edited comment on VELOCITY-904 at 12/13/19 8:23 AM:
--------------------------------------------------------------------
bq. I can't also help thinking that your use of null macro arguments is
somewhat a corner case of macro usages which is very specific to xwiki, but at
least it makes xwiki a good regression candidate.
Yeah I'm not very proud of that either but I have to work with history
unfortunately...
Currently trying to think about a cleaner way to deal with this macro return
need which involve a lot less hacking that people would use and which would be
less impacted by Velocity internals.
bq. To answer your question about what you can do to help speed up the release
process, well, all the tests and regressions that you do discover are certainly
helpful to improve the quality of the release, especially about backward
compatibility, and we thank you for them, but I'm not sure they're making the
release process faster...
I must say I was not expecting to find more issues when I asked the question
but yes not exactly the best to speed up the release :)
was (Author: tmortagne):
bq. I can't also help thinking that your use of null macro arguments is
somewhat a corner case of macro usages which is very specific to xwiki, but at
least it makes xwiki a good regression candidate.
Yeah I'm not very proud of that either but I have to work with history
unfortunately...
Currently trying to think about a cleaner way to deal with this macro return
need which involve a lot less hacking that people would use and which would be
less impacted by Velocity internals.
> Add a flag for better backward compatibility with null macro arguments
> ----------------------------------------------------------------------
>
> Key: VELOCITY-904
> URL: https://issues.apache.org/jira/browse/VELOCITY-904
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 2.0
> Reporter: Claude Brisson
> Assignee: Claude Brisson
> Priority: Minor
> Fix For: 2.2
>
>
> See [this
> comment|https://issues.apache.org/jira/browse/VELOCITY-542?focusedCommentId=16621819&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16621819]
> :
> {code}
> #macro(testmacro $parameter)
> $parameter
> #end
> #testmacro($return)
> {code}
> bq. which used to print "$return" (when $return is null or undefined) and we
> now get "$parameter".
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
