[ https://issues.apache.org/jira/browse/VELOCITY-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024437#comment-17024437 ]
Thomas Mortagne edited comment on VELOCITY-926 at 1/27/20 3:47 PM: ------------------------------------------------------------------- bq. global values provide defaults for missing arguments Sounds good to me. It would be enough to cover https://issues.apache.org/jira/browse/VELOCITY-926?focusedCommentId=17023076&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17023076. Even if it does not cover the other use cases discussed on the mailing list regarding the macro local context it's still better than nothing (at least we can say "hey it's Velocity's fault, we tried" and have a good excuse to have a simpler behavior ;)). was (Author: tmortagne): bq. global values provide defaults for missing arguments Sounds good to me. It would be enough to cover https://issues.apache.org/jira/browse/VELOCITY-926?focusedCommentId=17023076&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17023076. Even if it does not cover the other use cases discussed on the mailing list regarding the macro local context it's still better than nothing. > Regression: Macro arguments names cannot collide with external references > names > ------------------------------------------------------------------------------- > > Key: VELOCITY-926 > URL: https://issues.apache.org/jira/browse/VELOCITY-926 > Project: Velocity > Issue Type: Bug > Components: Engine > Affects Versions: 2.0, 2.1 > Reporter: Claude Brisson > Assignee: Claude Brisson > Priority: Major > Fix For: 2.2 > > > Consider the following example: > {code} > #macro( test $foo $bar ) > $foo $bar > #end > #set($foo = 'foo') > #set($bar = 'bar') > #test( $bar, $foo ) > {code} > The expected result would be "{{bar foo}}", but since 2.0 we get the > incorrect result "{{bar bar}}", as if the first inner {{$foo}} macro argument > was overwritting the second argument evaluation. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org