slachiewicz commented on code in PR #43: URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1524026355
########## velocity-engine-core/pom.xml: ########## @@ -139,29 +138,6 @@ </executions> </plugin> - <!-- post-processing of parser genereted source files --> - <plugin> - <groupId>com.google.code.maven-replacer-plugin</groupId> - <artifactId>replacer</artifactId> - <executions> - <execution> - <id>patch-parser-files</id> - <phase>process-sources</phase> - <goals> - <goal>replace</goal> - </goals> - <configuration> - <file>${project.build.directory}/generated-sources/javacc/org/apache/velocity/runtime/parser/TokenMgrError.java</file> - <replacements> - <replacement> - <token>static final int</token> - <value>public static final int</value> - </replacement> - </replacements> - </configuration> - </execution> - </executions> - </plugin> Review Comment: yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org