michael-o commented on PR #15: URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-2312456351
> > > > > I'm not familiar with the velocity-tools-view build process, but this is an approach that could easily be [replicated with Ant](https://stackoverflow.com/questions/8433588/retrieve-value-from-text-file-and-replace-a-string-constant-in-another-file-with). > > > > > > > > > > > > Do you consider it similar to mine: https://github.com/michael-o/activedirectory-dns-locator/blob/9dff8dfb3fce8890a8166be6de89b9c05ef77108/pom.xml#L92 > > > > > > > > > Yes, that should work! It looks like the same approach. > > > @michael-o Would you like me to put a PR together for this, or would you prefer to do it? > > > > > > I would appreciate one. Still occupied with some Maven releases... > > Fantastic! I'll post it in a few days (I don't use Maven for builds, so I need to get a special build/test environment together for this). Here are a few takeaways for you why my approach witha single module will *not* work for Velocity Tools: * It violates Maven principals to have one main artifact per module, two different namespaces are two main artifacts * How to solve different sets of dependencies at any scope? You can't. * How to build classifier artifacts of classier artifacts? JAvadoc/sources? You can't. * Downstream consumers doing analysis of dep trees? You can't. There are more arguments I cannot remember ATM, but we have here only one choice: Yet another module in the reactor which just reuses the sources somehow, rewrites them and builds appropriately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
