tmortagne commented on code in PR #54: URL: https://github.com/apache/velocity-engine/pull/54#discussion_r1793121546
########## velocity-engine-core/src/main/java/org/apache/velocity/util/introspection/MethodMap.java: ########## @@ -58,6 +60,8 @@ public class MethodMap TypeConversionHandler conversionHandler; + private static final Method trySetAccessible = MethodUtils.getMethodObject(Method.class, "trySetAccessible"); Review Comment: Yes, I was torned between how a static final variable should look like and being more obvious that this is the `trySetAccessible` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org