[ https://issues.apache.org/jira/browse/VELOCITY-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951080#comment-17951080 ]
Francis M Schlimmer commented on VELOCITY-989: ---------------------------------------------- [~cbrisson] I assume we would not want to change the API for DatabaseObjectsFactory? If we could the fix would be somewhat cleaner. > Multiple connection leaks in DataSourceResourceLoader > ----------------------------------------------------- > > Key: VELOCITY-989 > URL: https://issues.apache.org/jira/browse/VELOCITY-989 > Project: Velocity > Issue Type: Bug > Reporter: Francis M Schlimmer > Priority: Major > > The first case is in the implementation of FilterReader. It attempts to get a > statement from a result set after closing the result set. This always throws > an exception as it is an invalid operation after closing the result set, > which results in not closing the connection. > The second is in the getResourceReader method. In the happy path a > FilterReader is returned which eventually closes the connection when close is > called. However, if a template is not found, an exception is thrown without > closing the connection. > > Pull request here [https://github.com/apache/velocity-engine/pull/57] > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org