Thanks Chris, I will take a look at your code on PLC4X and I will modify the one that you added in the repository some time ago :D.
Best regards, Bertty On Tue, Sep 14, 2021 at 10:01 AM Christofer Dutz <[email protected]> wrote: > Hi all, > > you folks might be interested in what I did for PLC4X ... while building > only the java part is quite trivial, when building C, C++, Go etc it starts > getting tricky. So I added a prerequisiteScript which is run before the > build runs and this checks if all important tools are installed and if the > versions are right ... depending on which profiles are selected these > requirements change. > > For example PLC4X builds with Java 8 upwards, however if you want PLC4X, > you need at least Java 11 and if you wated Elasticsearch, you could at most > use Java 11 ... so depending on the profiles you select, the versions might > differ. > > If you find out what's needed, I would strongly reccomend to add a similar > script which simplifies onboarding of new folks drastically and has saved > my butt several times. > > Thinking about how many different languages we support and how challenging > usually the setup for such a build is, you will almost not find a single > email on our list with people having problems getting started with the > build. > > Chris > > > -----Ursprüngliche Nachricht----- > Von: bertty contreras <[email protected]> > Gesendet: Montag, 13. September 2021 18:36 > An: [email protected] > Betreff: Re: More version issues > > That would be awesome, it requires too much change to support scala-12, I > can help you if you need :D > > Best regards, > Bertty > > El lun, 13 sept 2021 a las 17:07, Gábor Gévay (<[email protected]>) > escribió: > > > Hi Bertty, > > > > Ok, thanks! > > > > I opened a PR for https://issues.apache.org/jira/browse/WAYANG-41 > > https://github.com/apache/incubator-wayang/pull/28 > > > > I will focus on planning the Emma integration now. Emma will work with > > Scala-11 and Java 8. > > > > Best, > > Gábor > > > > > > Bertty Contreras <[email protected]> ezt írta (időpont: 2021. szept. > > 13., H, 15:47): > > > > > > Hi Folks, > > > > > > I think we need to comments the profile scala-13, until we need it. > > > > > > About Java11, I think you recommend it as a nice idea, and I will be > > > working on it :D. > > > > > > What do you think? > > > > > > Best regards, > > > Bertty > > > > > > On Mon, Sep 13, 2021 at 2:06 PM Gábor E. Gévay <[email protected]> > > wrote: > > > > > > > Hello, > > > > > > > > Unfortunately, there are some more version issues: > > > > > > > > The scala-11 profile doesn’t work with Java 11. This is because > > > > Spark > > > > 2.4.8 doesn’t support Java 11: > > > > https://stackoverflow.com/questions/62894890/spark-for-java-11 > > > > A simple “fix” would be to tell users to use only Java 8 with the > > > > scala-11 profile, and (if possible) also add this requirement in > > > > the pom with the <requireJavaVersion>. Do you think this would be > > > > an acceptable fix? > > > > (Both the scala-11 and scala-12 profiles work with Java 8. The > > > > scala-12 profile works with Java 11 also. Our Travis builds > > > > currently test only with Java 8.) > > > > > > > > Another issue is that the scala-13 profile doesn’t work at all. > > > > This is because neither Flink nor Spark supports scala-13 yet, see > > > > https://issues.apache.org/jira/browse/SPARK-25075 > > > > https://issues.apache.org/jira/browse/FLINK-13414 > > > > Is there a reason for adding this profile? I.e., is there some > > > > system that needs scala-13? If not, then maybe we should just > > > > comment out this profile for now to keep things simple, until > > > > Spark and/or Flink start supporting it. > > > > > > > > Best, > > > > Gábor > > > > > > >
