PR approved. Thanks a lot Ricardo for the changes. Looking forward to more contributions in this new feature of Wayang :)
— Jorge > On 17 May 2023, at 10.08, Ricardo Martinez <[email protected]> > wrote: > > Dear Wayang Community, > > I have updated the code and seems that the checks are ok in the PR > https://github.com/apache/incubator-wayang/pull/315 is there something > else that should be done? > > Best regards. > Ricardo. > > Am Di., 9. Mai 2023 um 19:18 Uhr schrieb Alexander Alten <[email protected]>: > >> Hey Ricardo, >> >> The png license is weird, I’ll check that later :) The dead-link check can >> be ignored, we fixed that already. >> >> Cheers, >> —Alex >> >> >> — >> Alexander Alten >> PPMC Apache Wayang >> [email protected] >> >> @apachewayang >> >>> On 9. May 2023, at 13:20, Ricardo Martinez < >> [email protected]> wrote: >>> >>> Dear all, >>> >>> I opened a PR for the Dashboard (GUI - >>> >> https://www.google.com/url?q=https://github.com/apache/incubator-wayang/pull/315&source=gmail-imap&ust=1684255753000000&usg=AOvVaw1YOJfe1ZhlaLtqkOlAbvjG) >> and it fails to pass >>> the checks, one of them is license related, it is one PNG image, maybe I >>> missed something, if you have any suggestion for that, I will appreciate. >>> >>> The second failure happens in a link of the main README.md, with a dead >>> link. Is that something that happens in other branches or PRs? >>> >>> Best. >>> Ricardo. >> >> >> -- >> databloom AI, Inc. >> >> 3401 N. MIAMI AVE. STE 230 >> 33127 Miami, Florida >> United States >> >> >> -- Please consider the environment before printing this >> email -- >> >> >> >> Disclaimer: >> The content of this message is confidential. If you >> have received it by mistake, please inform us by an email reply and then >> delete the message. It is forbidden to copy, forward, or in any way reveal >> the contents of this message to anyone. The integrity and security of this >> email cannot be guaranteed over the Internet. Therefore, the sender will >> not be held liable for any damage caused by the message. >> >> > > -- > M.Sc. Eng. Ricardo Martínez > Berlin|Mexico City
