Hi Michalis, Please see my comment on your commit and update your build.sh accordingly. Let me know if that helps.
Best Kaustubh On Thu, May 25, 2023 at 4:39 PM Kaustubh Beedkar <[email protected]> wrote: > Hi Michalis, > > Let me take a look at this and get back to you. > > Best, > Kaustubh > > > On Wed, May 24, 2023 at 4:42 PM Michalis Vargiamis < > [email protected]> wrote: > >> I don't why this is happening. I made a commit with my changes on my >> fork of incubator-wayang. >> >> >> https://github.com/damik3/incubator-wayang/commit/63e757efaef1f52e3ef0f7e19a92387f29718a43 >> >> Inside the `my-build.sh` file are the commands I used. You can also see >> the print statement I added to the java file. >> >> If you could try it and tell me how it went it would be really helpful. >> >> >> Thank you, >> >> Michalis >> >> >> Στις 5/24/23 13:31, ο/η Kaustubh Beedkar έγραψε: >> > ./bin/wayang-submit org.apache.wayang.apps.wordcount.Main java >> > file:/Users/kbeedkar/Downloads/test-data >> > Kaustubh >> > >> > >> > On Wed, May 24, 2023 at 1:23 PM Michalis Vargiamis < >> > [email protected]> wrote: >> > >> >> Hello! >> >> >> >> >> >> The image isn't loading for some reason. Does it contain the additional >> >> commands that you used? Could you write them in the email instead of >> >> having them in the picture? >> >> >> >> >> >> Thank you, >> >> >> >> Michalis >> >> >> >> >> >> Στις 5/24/23 09:07, ο/η Kaustubh Beedkar έγραψε: >> >>> Hi Michalis, >> >>> after >> >>> mvn clean package -pl :wayang-assembly -Pdistribution >> >>> >> >>> image.png >> >>> >> >>> >> >>> >> >>> On Wed, May 24, 2023 at 12:44 AM Michalis Vargiamis >> >>> <[email protected]> wrote: >> >>> >> >>> I just added the print statement nothing more. >> >>> >> >>> Could you send me the exact commands you used to compile and run >> >>> the word >> >>> count? >> >>> >> >>> Thank you, >> >>> Michalis >> >>> >> >>> Στις Τρί 23 Μαΐ 2023 στις 22:09 ο χρήστης Kaustubh Beedkar < >> >>> [email protected]> έγραψε: >> >>> >> >>> > Hi Michalis, >> >>> > >> >>> > That works fine too as well as the WordCount example. >> >>> > >> >>> > Could you provide some more details on what changes you've >> made? >> >>> > >> >>> > Best, >> >>> > Kaustubh >> >>> > >> >>> > >> >>> > On Wed, May 24, 2023 at 12:02 AM Michalis Vargiamis < >> >>> > [email protected]> wrote: >> >>> > >> >>> > > Hi! >> >>> > > >> >>> > > I don’t think there’s a need for a draft pull request since >> my >> >>> changes >> >>> > are >> >>> > > minimal. >> >>> > > >> >>> > > Just add a print statement of your own into e.g. >> >>> > > >> >>> > > incubator-wayang/wayang-benchmark/code/main/java/org/ >> >>> > > apache/wayang/apps/wordcount/Main.java >> >>> > > >> >>> > > compile and run it and see if gets printed. >> >>> > > >> >>> > > Best, >> >>> > > Michalis >> >>> > > >> >>> > > Στις Τρί 23 Μαΐ 2023 στις 20:50 ο χρήστης Kaustubh Beedkar < >> >>> > > [email protected]> έγραψε: >> >>> > > >> >>> > > > Hi Michalis, >> >>> > > > >> >>> > > > for me both: >> >>> > > > mvn clean package -DskipTests >> >>> > > > mvn clean package -pl :wayang-assembly -Pdistribution >> >>> > > > >> >>> > > > work fine. >> >>> > > > >> >>> > > > Could create a draft pull request so I can try your changes >> >>> at my end? >> >>> > > > >> >>> > > > Best, >> >>> > > > Kaustubh >> >>> > > > >> >>> > > > >> >>> > > > On Tue, May 23, 2023 at 6:48 PM Michalis Vargiamis < >> >>> > > > [email protected]> wrote: >> >>> > > > >> >>> > > > > Yes I also tried >> >>> > > > > >> >>> > > > > ./mvnw clean package -DskipTests >> >>> > > > > ./mvnw clean package -pl :wayang-assembly -Pdistribution >> >>> > > > > >> >>> > > > > from the project root directory with my changes, but had >> >>> the same >> >>> > > > > results. Was it something else that you meant? >> >>> > > > > >> >>> > > > > >> >>> > > > > Thank you, >> >>> > > > > >> >>> > > > > Michalis >> >>> > > > > >> >>> > > > > >> >>> > > > > On 23/5/23 16:05, Zoi Kaoudi wrote: >> >>> > > > > > Running on its own, I meant you should not use the >> >>> assembly >> >>> > resease >> >>> > > > > directory at all but compile the source code you have >> >> locally. >> >>> > > > > > >> >>> > > > > > Στις Τρίτη 23 Μαΐου 2023 στις 03:00:24 μ.μ. CEST, >> ο >> >>> χρήστης >> >>> > > > > Michalis Vargiamis <[email protected]> >> έγραψε: >> >>> > > > > > >> >>> > > > > > The command I was using >> >>> > > > > > >> >>> > > > > > ./mvnw clean package -pl :wayang-assembly >> -Pdistribution >> >>> > > > > > >> >>> > > > > > already included the `clean package` and didn't make >> any >> >>> difference >> >>> > > > > > running it on its own. >> >>> > > > > > >> >>> > > > > > >> >>> > > > > > Thank you, >> >>> > > > > > >> >>> > > > > > Michalis >> >>> > > > > > >> >>> > > > > > >> >>> > > > > > On 23/5/23 15:41, Zoi Kaoudi wrote: >> >>> > > > > >> I have the feeling that the assembly build is taking >> >>> the code from >> >>> > > > > >> maven because we are using the wayang-0.6.1-SNAPSHOT >> in >> >>> the pom >> >>> > > file. >> >>> > > > > >> That's why you don't see your changes. Maybe a simple >> >>> mvnw clean >> >>> > > > > >> package should be the way. >> >>> > > > > >> >> >>> > > > > >> For the intellij, I also need to check because I get >> >>> the same >> >>> > error. >> >>> > > > > >> >> >>> > > > > >> Best >> >>> > > > > >> -- >> >>> > > > > >> Zoi >> >>> > > > > >> >> >>> > > > > >> Στις Τρίτη 23 Μαΐου 2023 στις 01:46:55 μ.μ. CEST, ο >> >> χρήστης >> >>> > Michalis >> >>> > > > > >> Vargiamis <[email protected]> έγραψε: >> >>> > > > > >> >> >>> > > > > >> >> >>> > > > > >> Hello! >> >>> > > > > >> >> >>> > > > > >> >> >>> > > > > >> If I try running the e.g. already existing >> >>> > > > > >> >> >>> > > > > >> >> >>> > > > > >> >>> > > > >> >>> > > >> >>> > >> >>> >> >> >> >> incubator-wayang/wayang-benchmark/code/main/java/org/apache/wayang/apps/wordcount/Main.java >> >>> > > > > >> >> >>> > > > > >> through IntelliJ (with the green play button it has on >> >>> Main), >> >>> > then I >> >>> > > > > >> get the following >> >>> > > > > >> >> >>> > > > > >> >> >>> > > > > >> >> >>> > > > > >> >> >>> > > > > >> On 23/5/23 14:34, Zoi Kaoudi wrote: >> >>> > > > > >>> Hi Michalis, >> >>> > > > > >>> not sure what the problem may be. I will also try it. >> >>> > > > > >>> Where you able to run your implementation with an IDE >> >> (eg. >> >>> > > intellij)? >> >>> > > > > >>> Best >> >>> > > > > >>> -- >> >>> > > > > >>> Zoi >> >>> > > > > >>> >> >>> > > > > >>> Στις Τρίτη 23 Μαΐου 2023 στις 10:10:32 π.μ. >> CEST, >> >> ο >> >>> > χρήστης >> >>> > > > > Michalis Vargiamis<[email protected]> >> <mailto: >> >>> > > > > [email protected]> έγραψε: >> >>> > > > > >>> >> >>> > > > > >>> Hello! >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >>> I'm having a little bit of trouble trying to add a >> new >> >>> benchmark >> >>> > > job. >> >>> > > > > So >> >>> > > > > >>> I have created a Main class under my newly created >> >> package >> >>> > > > > invertedindex >> >>> > > > > >>> with full path as below: >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >> >>> > > > >> >>> > > >> >>> > >> >>> >> >> >> >> incubator-wayang/wayang-benchmark/code/main/java/org/apache/wayang/apps/invertedindex >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >>> But when I follow the instructions mentioned in >> >>> > > > > >>> incubator-wayang/guides/tutorial.md by running >> >>> > > > > >>> >> >>> > > > > >>> ./mvnw clean package -pl :wayang-assembly >> -Pdistribution >> >>> > > > > >>> tar -xvf >> >>> > > > > >> >>> wayang-assembly/target/wayang-assembly-0.6.1-SNAPSHOT-dist.tar.gz >> >>> > > > > >>> cd wayang-0.6.1-SNAPSHOT >> >>> > > > > >>> echo "export WAYANG_HOME=$(pwd)" >> ~/.bashrc >> >>> > > > > >>> source ~/.bashrc >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >>> and then trying to run my code with >> >>> > > > > >>> >> >>> > > > > >>> ./bin/wayang-submit >> >>> org.apache.wayang.apps.invertedindex.Main >> >>> > > > > >>> >> >>> > > > > >>> I get >> >>> > > > > >>> >> >>> > > > > >>> Error: Could not find or load main class >> >>> > > > > >>> org.apache.wayang.apps.invertedindex.Main >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >>> Also note that if I add any changes to an existing >> >>> benchmark app >> >>> > > e.g. >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >> >>> > > > >> >>> > > >> >>> > >> >>> >> >> >> >> incubator-wayang/wayang-benchmark/code/main/java/org/apache/wayang/apps/wordcount/Main.java >> >>> > > > > >>> >> >>> > > > > >>> and follow the steps above, the changes don't happen. >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >>> What is the correct way of building and running my >> >>> newly created >> >>> > > > > >>> invertedindex benchmark? >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >>> Thank you, >> >>> > > > > >>> >> >>> > > > > >>> Michalis >> >>> > > > > >>> >> >>> > > > > >>> >> >>> > > > > >> >>> > > > >> >>> > > >> >>> > >> >>> >> >
