Ok … so here comes my review (I continued, even if the first check required me to vote -1)
-1 (binding) Chris [FAIL] Download all staged artifacts under the url specified in the release vote email. * The source bundle does not contain “apache-“ and “incubating”. Instead of wayang-0.7.0-source-release.zip it needs to be called apache-wayang-0.7.0-incubating-source-release.zip [MINOR] Verify the signature is correct. * First of all, the KEYS in the develop part doesn’t contain the gpg key used to sign the release [FAIL] Check if the signature references an Apache email address. * If I import the key in the release part, it does contain the key used to sign, however this key is not related to an apache id (the email in the key is supposed to be [email protected]<mailto:[email protected]>) [OK] Verify the SHA512 hashes. [OK] Unzip the archive. [OK] Verify the existence of DISCLAIMER, LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [FAIL] Verify the content of DISCLAIMER, LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. * Not using WIP disclaimer, therefor doing a full and thorough check * NOTICE refers to software by Sebastian Kruse. However, doesn’t define which parts and where they were copied from. It does seem as if it’s the entire content of wayang-utils-profile-db. * The LICENSE and NOTICE files of wayang-web-dashboard seem to refer to him as well, however I didn’t find any content from him * The wayang-web-dashboard module contains a full set of DISCLAIMER, LICENCE, NOTICE and README.md … this should not be needed. * The python module seems to contain a LICENSE file [OK] Verify the staged source README, RELEASE_NOTE files correspond to those in the extracted source bundle. [OK] Run RAT externally to ensure there are no surprises. [MINOR] Search for SNAPSHOT references * The module wayang-docs doesn’t seem to have been part of the release … it’s still on “0.7.0-SNAPSHOT”, the release should include the “web-documentation” profile. [FAIL] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file. * The module “wayang-web-dashboard” contains a README.md file, that credits a Copyright to DIMA/TU-Berlin [OK] Build the project according to the information in the README.md file. * Needed to make “mvnw” executable [MINOR] Build the project with all with-xyz profiles and tests enabled and an empty maven local repo. * Needed to manually adjust the parent pom version in “wayang-docs” * Got a build error in the last module: “[WARNING] LoadError: no such file to load -- /Users/cdutz/Temp/apache-wayang-0.7.0-incubating/wayang-docs/${env.GEM_HOME}/bin/bundle load at org/jruby/RubyKernel.java:1007 <main> at -e:1 “ Might be good to extend the prerequisite check. PS: I would have expected other IPMC members who “validated” this release to have found at least the first 2 failures. Von: Christofer Dutz <[email protected]> Datum: Dienstag, 25. Juli 2023 um 11:31 An: [email protected] <[email protected]> Betreff: AW: [VOTE] Incubator Apache Wayang Release 0.7.0 RC2 Could we please move the release down one directory … currently it’s at: https://dist.apache.org/repos/dist/dev/incubator/wayang/0.7.0/ But probably should be at https://dist.apache.org/repos/dist/dev/incubator/wayang/0.7.0/rc2/ Chris Von: Alexander Alten <[email protected]> Datum: Dienstag, 25. Juli 2023 um 07:33 An: [email protected] <[email protected]> Betreff: Re: [VOTE] Incubator Apache Wayang Release 0.7.0 RC2 Heya folks, Was on travel with limited connectivity. We need to initialize a vote on general@ for the release, here’s the last voting: https://www.mail-archive.com/[email protected]/msg76218.html Than we have to wait at least 72 hours :) Best, —Alex > On 24. Jul 2023, at 22:49, Christofer Dutz <[email protected]> wrote: > > No, > > Unfortunately, you’re not correct. This release is not finished yet and it > therefore needs to be > removed from the release area and moved to the dev area till the vote is over. > > The PPMC vote is over, however the IPMC (Incubator PMC) still needs to vote. > The vote needs to be cast on > [email protected]<mailto:[email protected]>. > > If your mentors have voted (which are all IPMC members), they can carry their > votes over. > However, you still need to wait for 72h at least on that vote. > > This is to allow other IPMC Members to also review the release. > > Chris > > > Von: Gláucia Esppenchutz <[email protected]> > Datum: Montag, 24. Juli 2023 um 22:03 > An: [email protected] <[email protected]> > Betreff: Re: [VOTE] Incubator Apache Wayang Release 0.7.0 RC2 > Hi Chris! > > Working on that now and noted for the next releases! > > Thanks :) > > Em seg., 24 de jul. de 2023 às 20:53, Christofer Dutz < > [email protected]> escreveu: > >> Also does the rc1 need to be removed. >> In their current location are they technically available via the Apache >> distribution network. >> >> Sorry for not having noticed that before. >> >> Chris >> >> >> Von: Christofer Dutz <[email protected]> >> Datum: Montag, 24. Juli 2023 um 21:50 >> An: [email protected] <[email protected]> >> Betreff: AW: [VOTE] Incubator Apache Wayang Release 0.7.0 RC2 >> Hi all, >> >> The release needs to immediately be moved from >> https://www.google.com/url?q=https://dist.apache.org/repos/dist/release/incubator/wayang/0.7.0/rc2/&source=gmail-imap&ust=1690836611000000&usg=AOvVaw1lIhAMojHwepQgPKoPNJTQ >> To: >> https://www.google.com/url?q=https://dist.apache.org/repos/dist/dev/incubator/wayang/0.7.0/rc2/&source=gmail-imap&ust=1690836611000000&usg=AOvVaw0jCGFRZ-5wjhG6QkWAU3eE >> >> The URL it is currently located at is for released software only and it >> should be moved from dev to release after the release was success full and >> the incubator PMC voted for it. >> >> You don’t need to create a new RC, just move the artifacts from “release” >> to “dev”. >> >> Chris >> >> >> >> Von: Alexander Alten <[email protected]> >> Datum: Montag, 24. Juli 2023 um 15:36 >> An: [email protected] <[email protected]> >> Betreff: Re: [VOTE] Incubator Apache Wayang Release 0.7.0 RC2 >> Hi Glaucia, >> >> Awesome, +1! >> >> Tank you, >> —Alex >> >>> On 23. Jul 2023, at 20:54, Gláucia Esppenchutz <[email protected]> >> wrote: >>> >>> Hi everyone, >>> >>> Since we acquired all the necessary votes, I will proceed tomorrow with >> the >>> release final steps :) >>> >>> Em qua., 19 de jul. de 2023 às 06:19, Jean-Baptiste Onofré < >> [email protected] <mailto:[email protected]>> >>> escreveu: >>> >>>> +1 (binding) >>>> >>>> Regards >>>> JB >>>> >>>> On Fri, Jul 14, 2023 at 11:42 AM Gláucia Esppenchutz < >>>> [email protected]> >>>> wrote: >>>> >>>>> Hi everyone, >>>>> >>>>> Incubator Apache Wayang 0.7.0 has been staged the *RC2* under [2] and >>>>> it’s time to vote >>>>> on accepting it for release. All Maven artifacts are available under >> [1]. >>>>> Voting will be open for 72hr. >>>>> >>>>> A minimum of 3 binding +1 votes and more binding +1 than binding -1 >>>>> are required to pass. >>>>> >>>>> Release tag: release/0.7.0 >>>>> Hash for the release tag: >>>>> >>>> >> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://github.com/apache/incubator-wayang/commit/62037b7384ffaf9f508be7c7a82f245bd71a9f5f%26source%3Dgmail-imap%26ust%3D1690743310000000%26usg%3DAOvVaw1kX56w4UT8y3MquJIWmBb2&source=gmail-imap&ust=1690836611000000&usg=AOvVaw0bCJuAwDQXHRqFTwLb1BfT >>>>> >>>>> Per [3] "Before voting +1 PMC members are required to download >>>>> the signed source code package, compile it as provided, and test >>>>> the resulting executable on their own platform, along with also >>>>> verifying that the package meets the requirements of the ASF policy >>>>> on releases." >>>>> >>>>> You can achieve the above by following [4]. >>>>> >>>>> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM >>>>> items in [4]) >>>>> [ ] -1 reject (explanation required) >>>>> >>>>> >>>>> OBS: I will be considering Alex's vote made on the previous thread: >>>>> [image: image.png] >>>>> >>>>> For any questions, please let me know. >>>>> >>>>> [1] >>>>> >> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://repository.apache.org/content/repositories/orgapachewayang-1012%26source%3Dgmail-imap%26ust%3D1690743310000000%26usg%3DAOvVaw1PotxEFaQrNQaC1atEJrEM&source=gmail-imap&ust=1690836611000000&usg=AOvVaw2fcgRKjG844_ZdqSt7oihi >>>>> [2] >>>> >> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://dist.apache.org/repos/dist/release/incubator/wayang/0.7.0/rc2/%26source%3Dgmail-imap%26ust%3D1690743310000000%26usg%3DAOvVaw2nc5n-aBgc3PAuBO-1Ecyo&source=gmail-imap&ust=1690836611000000&usg=AOvVaw0r6MPbEuZ4y2LUW5JYRa3_ >>>>> [3] >> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://www.apache.org/dev/release.html%2523approving-a-release%26source%3Dgmail-imap%26ust%3D1690743310000000%26usg%3DAOvVaw3561RO7Li2AxIWFTW0etw0&source=gmail-imap&ust=1690836611000000&usg=AOvVaw2lCxQfTK5Wjh-PmN64th-h >>>>> [4] >>>>> >>>> >> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://cwiki.apache.org/confluence/display/PLC4X/Validating%252Ba%252Bstaged%252BRelease%26source%3Dgmail-imap%26ust%3D1690743310000000%26usg%3DAOvVaw1IUoE16kiyBfncFHPR4LwF&source=gmail-imap&ust=1690836611000000&usg=AOvVaw0Cz113fb7eRfsqctDkkoF1 >>>>> >>>> >>> >>> >>> -- >>> Gláucia Esppenchutz >>> >>> ----------------------------------------------------- >>> Twitter: @lyuric19 >>> Linkedin: >> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://br.linkedin.com/pub/gl%2525C3%2525A1ucia-esppenchutz/47/81a/312%26source%3Dgmail-imap%26ust%3D1690743310000000%26usg%3DAOvVaw2VQLOCVsevpASjNQbJ9JeF&source=gmail-imap&ust=1690836611000000&usg=AOvVaw1zQeW4lIlVAT4TJF8sB60P >> >> >> -- >> databloom AI, Inc. >> >> 3401 N. MIAMI AVE. STE 230 >> 33127 Miami, Florida >> United States >> >> >> -- Please consider the environment before printing this >> email -- >> >> >> >> Disclaimer: >> The content of this message is confidential. If you >> have received it by mistake, please inform us by an email reply and then >> delete the message. It is forbidden to copy, forward, or in any way reveal >> the contents of this message to anyone. The integrity and security of this >> email cannot be guaranteed over the Internet. Therefore, the sender will >> not be held liable for any damage caused by the message. >> > > > -- > Gláucia Esppenchutz > > ----------------------------------------------------- > Twitter: @lyuric19 > Linkedin: > https://www.google.com/url?q=https://br.linkedin.com/pub/gl%25C3%25A1ucia-esppenchutz/47/81a/312&source=gmail-imap&ust=1690836611000000&usg=AOvVaw3ChSfwnIBXF0WDkmjZQSxb -- databloom AI, Inc. 3401 N. MIAMI AVE. STE 230 33127 Miami, Florida United States -- Please consider the environment before printing this email -- Disclaimer: The content of this message is confidential. If you have received it by mistake, please inform us by an email reply and then delete the message. It is forbidden to copy, forward, or in any way reveal the contents of this message to anyone. The integrity and security of this email cannot be guaranteed over the Internet. Therefore, the sender will not be held liable for any damage caused by the message.
