+1 (non-binding)
Thanks for preparing the candidate and here are my checks:
1. Build from source successfully after running `mvn clean install`
in wayang-0.7.1 branch.
2. Follow the tutorial to run the WordCount example locally with
wayang0.7.1, spark3.3.3 and hadoop3.3.0 successfully.
3. Run `find . -type f -name '*.xml' -exec grep -l "SNAPSHOT" {} \;` and
result is as follows:
./wayang-api/wayang-api-sql/pom.xml
./guides/pom-example.xml
./wayang-docs/pom.xml
We may update these files later.
4. Verify the sha512sum
of apache-wayang-incubating-0.7.1-source-release.zip.
6. Extract and inspect the source code for binaries.
7. Checked license in files.
Best,
Biao Geng
Alexander Alten-Lorenz <[email protected]> 于2023年9月6日周三 04:16写道：
> Just asking, as stated ;)
>
> Sent from my iPhone
>
> > On 05 Sep 2023, at 21:11, Christofer Dutz <[email protected]>
> wrote:
> >
> > Why use the WIP disclaimer?
> >
> > Your release is in good shape, and no one gave a -1 … why should you
> want to do that?
> >
> > Chris
> >
> >
> > Von: Alexander Alten <[email protected]>
> > Datum: Dienstag, 5. September 2023 um 17:24
> > An: [email protected] <[email protected]>
> > Betreff: Re: [VOTE] Apache Wayang (Incubator) v0.7.1 RC3
> > To make sure we pass I’d suggest we use the WiP disclaimer, what do you
> folks think?
> >
> > —a.
> >
> >> On 5. Sep 2023, at 17:05, Christofer Dutz <[email protected]>
> wrote:
> >>
> >> +1 (binding)
> >>
> >> Chris
> >>
> >>
> >> Good job folks … this release was in a much better state. You can be
> proud of yourself.
> >> I still did find a few little things, but nothing worth voting -1.
> >> Please just address them for the next build.
> >>
> >> Please carry this vote over to the incubator list once the vote goes
> over there.
> >>
> >> And please don’t click on any release buttons before the vote on the
> incubator general list passes ;-)
> >>
> >> Here my checks:
> >>
> >> [MINOR] The vote email should not refer to a tag, but a commit hash
> instead, as the tag can be re-declared and moved to another commit, a
> commit hash cannot be changed.
> >> [OK] Download all staged artifacts under the url specified in the
> release vote email.
> >> [OK] Verify the signature is correct.
> >> [OK] Check if the signature references an Apache email address.
> >> [OK] Verify the SHA512 hashes.
> >> [OK] Unzip the archive.
> >> [OK] Verify the existence of DISCLAIMER, LICENSE, NOTICE, README,
> RELEASE_NOTES files in the extracted source bundle.
> >>
> >> * As the non-WIP disclaimer is being used, applying all checks.
> >> [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files
> in the extracted source bundle.
> >> [MINOR] Run RAT externally to ensure there are no surprises.
> >>
> >> * The following files could use Apache Headers:
> >>
> >> o apache-wayang-incubating-0.7.1/general-todos.md
> >>
> >> o apache-wayang-incubating-0.7.1/python/README.md
> >>
> >> o apache-wayang-incubating-0.7.1/wayang-assembly/README.md
> >>
> >> o apache-wayang-incubating-0.7.1/wayang-benchmark/README.md
> >>
> >> o
> apache-wayang-incubating-0.7.1/wayang-docs/src/main/resources/README.md
> >> [MINOR] Search for SNAPSHOT references
> >>
> >> * It seems the following modules were not part of the release-build
> and therefore still use SNAPSHOT versions:
> >> * wayang-docs
> >> * The Python module’s setup.cfg still references the SNAPSHOT version.
> >> * Some documentation references the old SNAPSHOT version (Just info
> to regularly keep up to date):
> >> * README.md
> >> * guides/tutorial.md
> >> *
> wayang-docs/src/main/resources/how_contribute/preparing_releases.md
> >> [SUPER-MINOR] Search for Copyright references, and if they are in
> headers, make sure these files containing them are mentioned in the LICENSE
> file.
> >>
> >> * wayang-docs/src/main/resources/index.md references the wrong
> year-range (2020-2021) but should be (2020-2023)
> >> * wayang-docs/src/main/resources/_includes/footer.html (states 2021,
> but should be 2023)
> >> [MINOR] Build the project according to the information in the README.md
> file.
> >>
> >> * The parent pom is referencing Apache parent in version 25, however
> the latest version is 30 and projects should always reference the most
> recent version of the Apache parent.
> >> [MINOT] Build the project with all with-xyz profiles and tests enabled
> and an empty maven local repo.
> >>
> >> * Building with enabled “web-documentation” fails, as it references a
> no-longer existing parent in version 0.7.1-SNAPSHOT.
> >>
> >>
> >> Von: Gláucia Esppenchutz <[email protected]>
> >> Datum: Sonntag, 3. September 2023 um 19:50
> >> An: [email protected] <[email protected]>
> >> Betreff: [VOTE] Apache Wayang (Incubator) v0.7.1 RC3
> >> Apache Apache Wayang (Incubator) has been staged under [2] and it’s
> time to
> >> vote
> >> on accepting it for release. All Maven artifacts are available under
> [1].
> >> Voting will be open for 72 hours.
> >>
> >> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> >> are required to pass.
> >> After the voting from the community, the release will be submitted for
> >> Incubators Mentors' approval.
> >>
> >> Release tag: v0.7.1 RC3
> >> Hash for the release tag:
> >>
> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://github.com/apache/incubator-wayang/tree/wayang-0.7.1%26source%3Dgmail-imap%26ust%3D1694531189000000%26usg%3DAOvVaw1oAI_kVIac2ESf8IUnMVxr&source=gmail-imap&ust=1694545905000000&usg=AOvVaw37C7gWdtg3f86sx6VrtzD6
> >>
> >> Per [3] "Before voting +1 PMC members are required to download
> >> the signed source code package, compile it as provided, and test
> >> the resulting executable on their own platform, along with also
> >> verifying that the package meets the requirements of the ASF policy
> >> on releases."
> >>
> >> You can achieve the above by following [4].
> >>
> >> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM
> >> items in [4])
> >> [ ] -1 reject (explanation required)
> >>
> >>
> >> [1]
> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://repository.apache.org/content/repositories/orgapachewayang-1017%26source%3Dgmail-imap%26ust%3D1694531189000000%26usg%3DAOvVaw3LsHamoRME2ackQHtw78HX&source=gmail-imap&ust=1694545905000000&usg=AOvVaw1fUSfDcYzavqBtbgmW-nP0
> >> [2]
> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://dist.apache.org/repos/dist/dev/incubator/wayang/0.7.1/rc3/%26source%3Dgmail-imap%26ust%3D1694531189000000%26usg%3DAOvVaw32UsMNz1ZwUrNbgKIO8klj&source=gmail-imap&ust=1694545905000000&usg=AOvVaw2S8zhVd2-43wboG2eXYeqf
> >> [3]
> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://www.apache.org/dev/release.html%2523approving-a-release%26source%3Dgmail-imap%26ust%3D1694531189000000%26usg%3DAOvVaw0uQcTRegxgw5xvto-UgsEP&source=gmail-imap&ust=1694545905000000&usg=AOvVaw1B36UxxBicsdIuTWZvpg3t
> >> [4]
> >>
> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://cwiki.apache.org/confluence/display/PLC4X/Validating%252Ba%252Bstaged%252BRelease%26source%3Dgmail-imap%26ust%3D1694531189000000%26usg%3DAOvVaw1NaVJiOQjmFzcJS_l_VenW&source=gmail-imap&ust=1694545905000000&usg=AOvVaw3bZDq_iCPcJLULJKWfzWTf
> >
> >
> > --
> > databloom AI, Inc.
> >
> > 3401 N. MIAMI AVE. STE 230
> > 33127 Miami, Florida
> > United States
> >
> >
> > -- Please consider the environment before printing this
> > email --
> >
> >
> >
> > Disclaimer:
> > The content of this message is confidential. If you
> > have received it by mistake, please inform us by an email reply and then
> > delete the message. It is forbidden to copy, forward, or in any way
> reveal
> > the contents of this message to anyone. The integrity and security of
> this
> > email cannot be guaranteed over the Internet. Therefore, the sender will
> > not be held liable for any damage caused by the message.
>
> --
> databloom AI, Inc.
>
> 3401 N. MIAMI AVE. STE 230
> 33127 Miami, Florida
> United States
>
>
> -- Please consider the environment before printing this
> email --
>
>
>
> Disclaimer:
> The content of this message is confidential. If you
> have received it by mistake, please inform us by an email reply and then
> delete the message. It is forbidden to copy, forward, or in any way reveal
> the contents of this message to anyone. The integrity and security of this
> email cannot be guaranteed over the Internet. Therefore, the sender will
> not be held liable for any damage caused by the message.
>
>
