Hmm... pressed 'Send' too quickly...

I sent this e-mail to ask for a critical review and (hopefully) a confirmation that my reasoning is reasonable. It is not a mathematical proof that nothing will happen, I don't have time for that..., but it gives roughly my arguments that make /me/ quite confident in that nothing will break after committing. Important is also that there is a single page that features most of what is affected, namely:

http://website.openoffice.org/servlets/ProjectDocumentList

Additionally it is important to recognize that all anchors (<a>) will be affected by this change. Underline will be the default appearance for a link, but it will no longer be enforced using !important. I would like to commit it as soon as possible... it would definitely improve the look of the main page and the download page, and also pave the path for easier development of the new homepage.

g.,


Maarten


:murb: [maarten brouwers] wrote:
Hi,

Below you will find the diffs for tigris.css and inst.css if the !important statements are removed. Since it affects all websites though, committing it directly is not that smart.

Basically all font-*, text-* and color statements can be ignored, imho, quite safely. It will change the display, but will not hurt functionality. Similar for the page-break statement (is only print, not sure whether this is important, printing is dealt with with print.css). Padding and background image needed further attention. Which I gave, to limited extend:

__Tigris.css___
Line(914): styling relates to the file browser. Left padding is set to 0.
 Not so much a problem, but good to watch the changes to this page:
 http://website.openoffice.org/servlets/ProjectDocumentList
 Don't think it will hurt, see e.g.
    <td class="filebrowse" style="padding-right:0">
 Since it is tables all over the place here, I'm not afraid of tangible
 CSS here.

Line(1109): padding set to 0 for .navgroup dl dt; i.e. the sidebar.
 Don't think removing !important will hurt display of this sidebar, but
 by keeping an eye on the ProjectDocumentList we will know
 it immediately

Line(1531): affects .tabs th = old heritage... no longer in our html, but
 dealt with the old tab systems (which was table based :o )
 attempts force a background change

Line(1550): .tabset table.tabs = old heritage ... can't find class="tabset"
 attempts force a background change

__Inst.css___

Line(307) & Line(312) affects .navgroup background. makes sure there
is no background. Can't see why it should have an effects since there is no
 CSS in the default site, not inline, not alm.css, that overrides this.

Line(318,321): Sets the fade backgrounds for the navbar... can't see where
 this should be overriden... not inline, not in alm.css

Line(440): Sets a background colour for rightcol h3 ...
 this seems like old heritage...




Bottom line: committing with the diffs as below is not a problem. If it is a problem it is immediately visible at:
http://website.openoffice.org/servlets/ProjectDocumentList

Home page and download page should look better again, since the underline statements for the a:link is no longer enforced by inst.css at line 409.

I still do wonder, though it only contains very specificly targetted css, where

http://www.openoffice.org/branding/css/onlinehelp.css
and
http://www.openoffice.org/branding/css/alm.css

are located ... they are not in

/cvs/look/www/overrides/static/csi/css/tigris.css

g.,


Maarten

(below indeed the diffs)









Index: tigris.css
===================================================================
RCS file: /cvs/look/www/overrides/static/csi/css/tigris.css,v
retrieving revision 1.10
diff -r1.10 tigris.css
220c220
< font-family: "Lucida Grande", Verdana, Arial, Helvetica, sans-serif !important;
---
> font-family: "Lucida Grande", Verdana, Arial, Helvetica, sans-serif ;
286c286
<       font-family: Verdana, Arial, Helvetica, sans-serif !important;
---
>       font-family: Verdana, Arial, Helvetica, sans-serif;
352c352
<       color: #334 !important;
---
>       color: #334;
356c356
< a:active, a:hover, #navcol a:active, #navcol a:hover { color: #f30 !important; }
---
> a:active, a:hover, #navcol a:active, #navcol a:hover { color: #f30 ; }
358c358
<       color: #fff !important;
---
>       color: #fff;
366c366
<       color: #000 !important;
---
>       color: #000;
371c371
<       color: #9cf !important;
---
>       color: #9cf;
375c375
<       color: #555 !important;
---
>       color: #555;
379c379
<       color: #222 !important;
---
>       color: #222;
833c833
<       text-align: right !important;
---
>       text-align: right;
837c837
<       text-align: center !important;
---
>       text-align: center;
914c914
<       padding-left: 0 !important;
---
>       padding-left: 0;
1004c1004
<       page-break-after: always !important;
---
>       page-break-after: always;
1109c1109
<       padding-left: 0px !important;
---
>       padding-left: 0px;
1531c1531
< background: #efefef url(../images/gradient_light.gif) repeat-x !important;
---
>       background: #efefef url(../images/gradient_light.gif) repeat-x ;
1550c1550
< background: #efefef url(../images/gradient_light.gif) repeat-x !important;
---
>    background: #efefef url(../images/gradient_light.gif) repeat-x ;


Index: inst.css
===================================================================
RCS file: /cvs/look/www/overrides/static/csi/css/inst.css,v
retrieving revision 1.53
diff -r1.53 inst.css
7,8c7,8
<       font-size: 1.1em !important;
<       font-weight: bold !important;
---
>       font-size: 1.1em ;
>       font-weight: bold ;
15c15
<     color: #fff !important;
---
>     color: #fff ;
76c76
<     color: #698ed1 !important;
---
>     color: #698ed1 ;
208c208
<     font-size: 1.1em !important;
---
>     font-size: 1.1em ;
218c218
<     color: #06348C !important;
---
>     color: #06348C ;
307c307
<     background-image: none !important;
---
>     background-image: none ;
312c312
<     background-image: none !important;
---
>     background-image: none ;
318,321c318,321
<       /* !important to override div-rules from tigris.css */
< background-image: url("../images/lesslightbluefadeout.gif") !important;
<     background-repeat: repeat-y !important;
<     background-position: top right !important;
---
>       /*  to override div-rules from tigris.css */
>     background-image: url("../images/lesslightbluefadeout.gif") ;
>     background-repeat: repeat-y ;
>     background-position: top right ;
329c329
<    font-weight: bold !important;
---
>    font-weight: bold ;
346c346
<       font-weight: bold !important;
---
>       font-weight: bold ;
355,357c355,357
<       background-image: url(../images/icon_help_sml.gif) !important;
<       background-repeat: no-repeat !important;
<       background-position: 97% !important;
---
>       background-image: url(../images/icon_help_sml.gif) ;
>       background-repeat: no-repeat ;
>       background-position: 97% ;
396c396
<       color: #06348C !important;
---
>       color: #06348C ;
400c400
<       color: #0033CC !important;
---
>       color: #0033CC ;
404,405c404,405
<       color: #698ed1 !important;
<       text-decoration: none !important;
---
>       color: #698ed1 ;
>       text-decoration: none ;
409c409
<       text-decoration: underline !important;
---
>       text-decoration: underline ;
413c413
<       text-decoration: none !important;
---
>       text-decoration: none ;
417c417
<       font-size: 110% !important;
---
>       font-size: 110% ;
425c425
<       background-color: #fff !important;
---
>       background-color: #fff ;
440c440
<     background-color: #036 !important;
---
>     background-color: #036 ;
442,443c442,443
<     font-size: 1.2em !important;
<     font-weight:bold !important;
---
>     font-size: 1.2em ;
>     font-weight:bold ;
448c448
<     font-size: 1em !important;
---
>     font-size: 1em ;
456c456
<     font-size: 1em !important;
---
>     font-size: 1em ;
465c465
<     font-size: 1em !important;
---
>     font-size: 1em ;
476c476
<     color: #fff; /* !important; */
---
>     color: #fff; /* ; */
750c750
<       font-family: Verdana, Arial, Helvetica, sans-serif !important;
---
>       font-family: Verdana, Arial, Helvetica, sans-serif ;


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to