Kay Schenk wrote:

Hello Kay,

Marcus Lange wrote:
Ivan M wrote:
2009/2/9 Marcus Lange <[email protected]>:
there's anything else that I can help with.
The idea from Gordon could be implemented (to move the variables from
index.html to the ../download.js). I've tried this and trashed the whole
website, so I had to undo my changes. Maybe you have more luck... ;-)

I'll leave this to someone far more capable than me - Kay :)
For pages that have an OOo version other than the latest, such as
http://download.openoffice.org/2.4.2/
the variable can be overwritten in the pages' HTML to specify an older version.

Well I'm not sure I'm all that much more capable, but....right now the DL script and other elements on the home page itself count on this being defined elsewhere (i.e. the main page). What I'd like to know is in what other pages besides the DL js that this is needed. It's conceivable, and maybe nicer, if it were just kept in a standalone js file that could be used in various pages. This way it would only need to be maintained in one place.

Please avoid to create new js files for single things that could be centralized. IMHO we should keep the number of files as small as possible.

But, since I didn't get to this over last weekend, if someone could let me know where else the version number is required so I could take a look, I would be much obliged.

I know of the following variables:

"download.openoffice.org./index.html":
var VERSION = "3.0.1";

"download.openoffice.org./2.4.2/index.html":
var VERSION = "2.4.2";

"download.openoffice.org./test/index.html" (created by myself):
var RC_NAME    = "OpenOffice.org 3.1.0 Release Candidate 1";
var RC_BUILD   = "OOO310_m123";
var RC_VERSION = "3.1.0rc1";

var DEV1_TEXT  = "(codeline OOO310)";
var DEV1_BUILD = "OOO310_m1";
var DEV1_VERSION = "3.1";

var DEV2_TEXT  = "(codeline DEV300)";
var DEV2_BUILD = "DEV300_m41";
var DEV2_VERSION = "3.x";

IMHO all can be moved into "download.js" and rename VERSION into STABLE_VERSION to make it unique compared to the others.

When having all in the js file, then the variables can be deleted in the HTML files.
--> Now only one file has to be edited when we have to change version data.

But this data can be overwritten when leaving a vaiable in a HMTL file.
--> Possiblity to overwrite version data for future 2.4.x releases in the "download.openoffice.org./2.4.2/index.html".

I hope I've explained it well enough. :-)

this idea is even better. Variables that can be used globally but can be overwritten locally, too. :-)
>>>>
One other thing comes into my mind:

I would like to change the location in the URL, from
"download.openoffice.org/test" to a name that points better to unstable
builds in general. When looking to the URL and see "test", then I don't
expect something that has a real and official character. It's more about
websites or scripts that are tested by the webmasters.

I can think of names like "next", "current", "dev", "unstable", "ng" (from StarTrek's Next Generation)? IMHO the name should be short but still unique
in its meaning. IMHO a good thing for a proposal.

Next or dev sound good to me (nice and short) - but perhaps others
could weigh in and share their thoughts.

2009/2/10 Marcus Lange <[email protected]>:
Hi Ivan,

we've noticed a problem with the 2.4.2 download website
"download.openoffice.org/2.4.2". The old style references are still used and
therefore the website looks now trashed.

Trashed is a good way of putting it :)
The page hadn't been updated to reflect the changes recently made to
download.js (splitting of languages into languages.js as far as I can
see) so the download button wasn't even showing - I've fixed it now,

Thanks

but we should keep a list of all the pages that make use of
download.js so that when updates like this are made, JS errors don't
stop people from being able to download.
I've made a basic list on the wiki:
http://wiki.services.openoffice.org/wiki/Website/Pages_using_download.js

Yes, but IMHO then another step should be done and list also pages that reference the other files like "languages.js and "exception.css". I've add these to the wiki page.

Best regards

Marcus

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to