[
https://issues.apache.org/jira/browse/WEEX-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064328#comment-16064328
]
ASF GitHub Bot commented on WEEX-34:
------------------------------------
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/476
Android feature yoga
Related issue : https://issues.apache.org/jira/browse/WEEX-34
Upgrade `css-layout` to `yoga`.
This is a huge PR, better reviewing by commits.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex android-feature-yoga
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #476
----
commit ae35fa1e45e44fab7815b5cd6212295d067e3f53
Author: sospartan <[email protected]>
Date: 2017-06-21T11:06:31Z
* [android] Upgrade css-layout to yoga
WXDomObject now inherit YogaNode, which is wrapper for object in jni.
minSDKVersion change to 15, the yoga library required. I’ve make a PR to
yoga, and it accepted by yoga. So yoga will change minSDKVersion to 14. After
that, we can change it back to 14 too.
Spacing from old css-layout library will stay, because the
ImmutableDomObject use it.
Clean css-layout code will in another seperate commit.
Some new rule:
- 'Only leaf nodes with custom measure functionsshould manually mark
themselves as dirty
- 'Cannot add child: Nodes with measure functions cannot have children'
Measure Function in Weex are modified according these rules.
The ‘clone’ method from WXDomObject is deprecated. Use a ‘asResult’ to
return the data object need by components.
commit 19bf036f986502eaf46d7a9ff5e5ab65a14b3db8
Author: sospartan <[email protected]>
Date: 2017-06-26T09:43:49Z
* [android] clean up csslayout code
commit 9e388213ef9df1d080b676c8ba501446dc84e744
Author: sospartan <[email protected]>
Date: 2017-06-27T05:42:26Z
* [android] disable junit test
New YogaNode use jni, in junit it's hard to mock with tiny modification.
Disable temporarily, fix junit by another PR.
----
> Update csslayout to Yoga
> ------------------------
>
> Key: WEEX-34
> URL: https://issues.apache.org/jira/browse/WEEX-34
> Project: Weex
> Issue Type: Task
> Reporter: sospartan
>
> Weex bundle old csslayout source code, which is out of date.
> The library is renamed to 'yoga'.
> In android side, it's provided jcenter artifacts:
> > https://bintray.com/facebook/maven/com.facebook.yoga%3Ayoga
> latest version is 1.4.2
> After change to remote dependency, source code under
> 'android/sdk/src/main/java/com/taobao/weex/dom/flex' could be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
