[ 
https://issues.apache.org/jira/browse/WEEX-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196663#comment-16196663
 ] 

ASF GitHub Bot commented on WEEX-78:
------------------------------------

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/770
  
    
    <!--
      0 failure: 
      2 warning:  No Changelog chan..., This PR should up...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a 
href="http://github.com/danger/danger-js/";>dangerJS</a>
    </p>



> The ES7 methods should be removed to improve compatibility
> ----------------------------------------------------------
>
>                 Key: WEEX-78
>                 URL: https://issues.apache.org/jira/browse/WEEX-78
>             Project: Weex
>          Issue Type: Bug
>          Components: JSFM
>            Reporter: Hanks Zhang
>            Assignee: sospartan
>              Labels: patch
>
> The implementation of event bubbling in JSF is using 
> `Array.prototype.includes` API [1] which is defined in ECMAScript 2016 (ES7). 
> This method is not compatible with low version js engines and should be 
> replaced.
> [1] 
> https://github.com/apache/incubator-weex/blob/4bc653653c1460dcad0642ef654e593c89ebaaf1/html5/runtime/vdom/Element.js#L412



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to