[jira] [Commented] (WEEX-651) [Android] fix list unable to slide when sticky item has events

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WEEX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660594#comment-16660594
 ] 

ASF GitHub Bot commented on WEEX-651:
-------------------------------------

YorkShen closed pull request #1660: [WEEX-651][Android] fix data not bind when 
non-recyclable item is lazy in list
URL: https://github.com/apache/incubator-weex/pull/1660
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index e025c3b850..e377ad9164 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -968,10 +968,10 @@ public ListBaseViewHolder onCreateViewHolder(ViewGroup 
parent, int viewType) {
             if (component.getRealView() != null) {
               return new ListBaseViewHolder(component, viewType);
             } else {
-              ((WXCell) component).lazy(false);
+              component.lazy(false);
               component.createView();
               component.applyLayoutAndEvent(component);
-              return new ListBaseViewHolder(component, viewType);
+              return new ListBaseViewHolder(component, viewType, true);
             }
           } else if (component instanceof WXBaseRefresh) {
             return createVHForRefreshComponent(viewType);
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
index 2419b6ec71..3c332da181 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
@@ -47,6 +47,11 @@ public ListBaseViewHolder(WXComponent component, int 
viewType) {
     isRecycled = component.canRecycled();
   }
 
+  public ListBaseViewHolder(WXComponent component, int viewType, boolean 
forceBindData) {
+    this(component, viewType);
+    isRecycled = isRecycled || forceBindData;
+  }
+
   public ListBaseViewHolder(View view, int viewType) {
     super(view);
     mViewType = viewType;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Android] fix list unable to slide when sticky item has events
> --------------------------------------------------------------
>
>                 Key: WEEX-651
>                 URL: https://issues.apache.org/jira/browse/WEEX-651
>             Project: Weex
>          Issue Type: Bug
>            Reporter: yxp
>            Assignee: Adam Feng
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)