[
https://issues.apache.org/jira/browse/WEEX-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692977#comment-16692977
]
ASF GitHub Bot commented on WEEX-664:
-------------------------------------
YorkShen closed pull request #1784: [WEEX-664][weex_core] fix RTL bug when
flex-direction is column or column-reverse
URL: https://github.com/apache/incubator-weex/pull/1784
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/weex_core/Source/core/layout/layout.cpp
b/weex_core/Source/core/layout/layout.cpp
index 8ffdf48b28..eafa819377 100644
--- a/weex_core/Source/core/layout/layout.cpp
+++ b/weex_core/Source/core/layout/layout.cpp
@@ -657,7 +657,7 @@ namespace WeexCore {
}
bool verticalRTL = false;
- if (mCssStyle->mFlexWrap != kNoWrap && mLayoutResult->mLayoutDirection
== kDirectionRTL) {
+ if (mLayoutResult->mLayoutDirection == kDirectionRTL) {
verticalRTL = mCssStyle->mFlexWrap != kWrapReverse;
} else {
verticalRTL = mCssStyle->mFlexWrap == kWrapReverse;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [weex_core] RTL performance is incorrect
> ----------------------------------------
>
> Key: WEEX-664
> URL: https://issues.apache.org/jira/browse/WEEX-664
> Project: Weex
> Issue Type: Bug
> Components: Android, iOS
> Affects Versions: 0.19
> Reporter: KAI TIAN
> Assignee: YorkShen
> Priority: Major
> Fix For: 0.19
>
>
> RTL performance is incorrect when flex-direction:column or
> flex-direction:column-reverse
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
