On 28 February 2016 at 20:11, Sam Ruby <[email protected]> wrote:
> Whatever is blocking you from testing this change is the bug I would like
> to work on.

I cannot get Whimsy working locally.

I have got as far as seeing the index page but nothing else works.

e.g.

The requested URL /roster/committer/ was not found on this server.

I added what I thought was the correct config and restarted Apache:

    Alias /whimsy/roster/committer/ /srv/whimsy/www/roster/committer
    <Location /whimsy/roster/committer>
        PassengerBaseURI /whimsy/roster/committer
        PassengerAppRoot /srv/whimsy/www/roster/committer
        PassengerAppEnv development
        Options -Multiviews
    </Location>

==

It was a lot easier when there was a test installation.
I think we should consider having a shared test installlation which is
auto-updated from a different Git branch.
Anything else is going to be a big barrier for new developers.

> On Feb 28, 2016 2:21 PM, "sebb" <[email protected]> wrote:
>
>> I have two PGP keys which display concatenated.
>>
>> I think the following patch will fix it, but cannot test it:
>>
>>
>> diff --git a/www/roster/views/committer.js.rb
>> b/www/roster/views/committer.js.rb
>> index 93ac1af..27856d2 100644
>> --- a/www/roster/views/committer.js.rb
>> +++ b/www/roster/views/committer.js.rb
>> @@ -104,8 +104,12 @@
>>
>>        if @committer.pgp
>>          _tr do
>> -          _td 'PGP key'
>> -          _td @committer.pgp
>> +          _td 'PGP keys'
>> +          _td do
>> +            _ul @committer.pgp do |key|
>> +              _li {key}
>> +            end
>> +          end
>>          end
>>        end
>>

Reply via email to