[
https://issues.apache.org/jira/browse/WHIMSY-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061518#comment-16061518
]
Sam Ruby commented on WHIMSY-109:
---------------------------------
Can I get you to state what your concern is?
Note that if you can Dir.chdir with a block, the current working directory is
restored at the exit of the block:
https://ruby-doc.org/core-2.4.1/Dir.html#method-c-chdir
> Code uses Dir.chdir and Dir.pwd without sync
> --------------------------------------------
>
> Key: WHIMSY-109
> URL: https://issues.apache.org/jira/browse/WHIMSY-109
> Project: Whimsy
> Issue Type: Bug
> Reporter: Sebb
> Assignee: Sebb
>
> The lib/whimsy code uses Dir.chdir in two places:
> asf/git.rb and svn.rb
> These are done under Mutex synchronisation.
> However AFAICT they use different instances of the Mutex.
> Also, there is an instance of Dir.pwd in the file asf/rack.rb
> This does not use a Mutex at all.
> So unless there is some other mutual exclusion occurring, there is a
> potential for confusion over the actual working directory.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
